XMLHttpRequest: minor cleanup of URLSearchParams test #5154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notifying @Manishearth, @caitp, @emilio, @hallvors, @ibelem, @jdm, @jungkees, @kangxu, @mathiasbynens, @ronkorving, and @wisniewskit. (Learn how reviewing works.) |
Firefox (nightly channel)Testing web-platform-tests at revision 5a6d4b3 |
Chrome (unstable channel)Testing web-platform-tests at revision 5a6d4b3 |
hiroshige-g
added a commit
to hiroshige-g/wpt
that referenced
this pull request
Dec 13, 2019
`script element's node document` is re-evaluated after script evaluation, and thus if a script is moved to another Document during its own evaluation, `currentScript` of the *new* document could be updated. After web-platform-tests#5154, `currentScript` is always set/reset on the same Document, which is expected, and tested so here.
hiroshige-g
added a commit
to hiroshige-g/wpt
that referenced
this pull request
Dec 13, 2019
In the spec before whatwg/html#5154, `script element's node document` is re-evaluated after script evaluation, and thus if a script is moved to another Document during its own evaluation, `currentScript` of the *new* document could be updated. After web-platform-tests#5154, `currentScript` is always set/reset on the same Document, which is expected, and tested so here.
domenic
pushed a commit
that referenced
this pull request
Mar 10, 2021
In the spec before whatwg/html#5154, `script element's node document` is re-evaluated after script evaluation, and thus if a script is moved to another Document during its own evaluation, `currentScript` of the *new* document could be updated. After #5154, `currentScript` is always set/reset on the same Document, which is expected, and tested so here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.