HTML: <form>'s invalid event is not to be supported #23380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
domenic,
foolip,
jdm,
jgraham,
tkent-google,
zcorpan and
zqzhang
3 tasks
domenic
reviewed
May 4, 2020
| invalid.addEventListener("invalid", t.step_func(() => counter++)); | ||
| invalid.oninvalid = t.step_func(() => counter++); | ||
| submitter.click(); | ||
| assert_equals(counter, 2); |
There was a problem hiding this comment.
A browser could theoretically pass this if it fired invalid at both the form and the control, but did not support the oninvalid property on either.
I think this would be better if each function pushed a unique value into an array, and then you did assert_array_equals. Or at least two separate counters, one for the form and one for the control.
There was a problem hiding this comment.
Fair, pushed something better.
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 4, 2020
Also tidy up some formatting. Tests: web-platform-tests/wpt#23380. Closes #4626.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatwg/html#5507.