-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dispatching invalid at <form> #4626
Comments
I confirmed Edge didn't do it too. |
To fix this, step 6.3.1 of https://html.spec.whatwg.org/#concept-form-submit needs to be removed. A WPT test to confirm the event does not fire would also be good. |
So removing The point 6.3.1 would solve this issue from https://html.spec.whatwg.org/#concept-form-submit. Am I right? |
@rahulpurohit29 |
There is also a note at the bottom of 4.10.1.4 that should be updated or removed:
|
Also tidy up some formatting. Tests: ... Closes #4626.
Also tidy up some formatting. Tests: web-platform-tests/wpt#23380. Closes #4626.
Do not fire `invalid` event on form elements This is a follow-up to my [previous PR](#27100) suggested by @gterzian. `invalid` event on the `<form>` element has been [recently removed](whatwg/html#4626) from the spec. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27133 <!-- Either: --> - [x] [WPT test](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/historical.window.js) marked as passing
Do not fire `invalid` event on form elements This is a follow-up to my [previous PR](#27100) suggested by @gterzian. `invalid` event on the `<form>` element has been [recently removed](whatwg/html#4626) from the spec. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #27133 <!-- Either: --> - [x] [WPT test](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/html/semantics/forms/form-submission-0/historical.window.js) marked as passing
I also found none of Chrome, Firefox and Safari dispatches
invalid
event targeting the<form>
.Originally posted by @tkent-google in #4621 (comment)
It seems we should remove this functionality given that nobody complained about it for so long.
The text was updated successfully, but these errors were encountered: