Add <form>'s "firing submission events" flag #4621

tkent-google · 2019-05-14T03:40:59Z

This fixes #4620

At least two implementers are interested (and none opposed):
- Chrome: Partially implemented. Interested in following this
- Firefox: Partially implemented.
- Safari: Already implemented.
Tests are written and can be reviewed and commented upon at:
- html: Add a testcase for submit event reentrancy protection web-platform-tests/wpt#16811
Implementation bugs are filed:
- Chrome: https://bugs.chromium.org/p/chromium/issues/detail?id=963251
- Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1551758
- Safari: N/A; Already implemented this.

(See WHATWG Working Mode: Changes for more details.)

/form-control-infrastructure.html ( diff )

This fixes whatwg#4620

Specification: whatwg/html#4621

annevk · 2019-05-14T12:02:04Z

So reentrancy for the invalid event is not prevented?

domenic

LGTM editorially although I am also curious about @annevk's question. We may want to add a test for the invalid event causing reentrancy (e.g. bailing out after 5 recursions).

domenic · 2019-05-14T17:16:45Z

source

+ and probably informed the user of this) then
+ <span data-x="concept-event-fire">fire an event</span> named
+ <code data-x="event-invalid">invalid</code> at the <var>form</var> element and then return.
+ </p></li>


Nit: this wrapping introduces an observable space after the period. I will fix.

Also removes comments that are no longer helpful because the structure is now obvious from the actual spec text.

tkent-google · 2019-05-15T00:30:18Z

So reentrancy for the invalid event is not prevented?

Good point!
Chrome and Firefox seems to set the flag to true after interactive validation. Safari seems to set the flag before interactive validation. IMO Safari's behavior is more reasonable.

I also found none of Chrome, Firefox and Safari dispatches invalid event targeting the <form>.

domenic · 2019-05-15T00:35:30Z

Wow, OK. Can you take care of updating this PR and tests? I think it'll make more sense to just land everything together. This would include a -historical test that there is no invalid event fired at the form

I guess we should name the boolean "firing submission events" or something since it's also about the invalid events.

- Rename the flag; firing submit event -> firing submission events

tkent-google · 2019-05-15T00:48:13Z

Updated this PR. Will update the WPT PR.
I didn't the remove invalid event stuff. IMO it should be discussed separately.

domenic · 2019-05-15T00:50:12Z

I guess that's fair.

annevk · 2019-05-15T12:11:05Z

I filed #4626 on invalid and <form>.

tkent-google · 2019-05-15T14:22:07Z

source

+ <var>form</var> and examine the result: if the result is negative (the constraint validation
+ concluded that there were invalid fields and probably informed the user of this) then <span
+ data-x="concept-event-fire">fire an event</span> named <code
+ data-x="event-invalid">invalid</code> at the <var>form</var> element and then return.</p></li>


Need to reset the flag here too. I'll update the PR tomorrow.

I'll update it now so we can merge; I want to rebase #4597 on top.

Specification change: whatwg/html#4621

…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811

Specification change: whatwg/html#4621

…entrancy protection, a=testonly Automatic update from web-platform-tests html: Add a testcase for submit event reentrancy protection (#16811) Specification change: whatwg/html#4621 -- wp5At-commits: 7ffd31b4eb23f0d99d5333ae2056b8c6896f463b wpt-pr: 16811 UltraBlame original commit: b05ea3f35ab4136dd53da0fb0ec41d0819b8a0f7

Add <form>'s "firing submit event" flag

a242392

This fixes whatwg#4620

tkent-google mentioned this pull request May 14, 2019

Add form.requestSubmit() #4597

Merged

3 tasks

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request May 14, 2019

html: Add a testcase for submit event reentrancy protection

74df56e

Specification: whatwg/html#4621

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request May 14, 2019

html: Add a testcase for submit event reentrancy protection

582eded

Specification: whatwg/html#4621

tkent-google mentioned this pull request May 14, 2019

html: Add a testcase for submit event reentrancy protection web-platform-tests/wpt#16811

Merged

domenic approved these changes May 14, 2019

View reviewed changes

Wrapping tweak.

3f72681

Also removes comments that are no longer helpful because the structure is now obvious from the actual spec text.

domenic added the topic: forms label May 14, 2019

- Protect interactive validation too

fba38af

- Rename the flag; firing submit event -> firing submission events

tkent-google changed the title ~~Add <form>'s "firing submit event" flag~~ Add <form>'s "firing submission events" flag May 15, 2019

tkent-google mentioned this pull request May 15, 2019

html: Add a test for form.requestSubmit() web-platform-tests/wpt#16743

Merged

annevk mentioned this pull request May 15, 2019

Dispatching invalid at <form> #4626

Closed

annevk approved these changes May 15, 2019

View reviewed changes

tkent-google commented May 15, 2019

View reviewed changes

Also reset there

b12c1a8

domenic merged commit cb55dca into whatwg:master May 15, 2019

tkent-google added a commit to web-platform-tests/wpt that referenced this pull request May 15, 2019

html: Add a testcase for submit event reentrancy protection (#16811)

7ffd31b

Specification change: whatwg/html#4621

marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 23, 2019

html: Add a testcase for submit event reentrancy protection (#16811)

ec16e9d

Specification change: whatwg/html#4621

hober mentioned this pull request Dec 10, 2019

HTML horizontal review: Form controls w3ctag/design-reviews#449

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add <form>'s "firing submission events" flag #4621

Add <form>'s "firing submission events" flag #4621

tkent-google commented May 14, 2019 •

edited by pr-preview bot

Loading

annevk commented May 14, 2019

domenic left a comment

domenic May 14, 2019

tkent-google commented May 15, 2019

domenic commented May 15, 2019

tkent-google commented May 15, 2019

domenic commented May 15, 2019

annevk commented May 15, 2019

tkent-google May 15, 2019

domenic May 15, 2019

Add <form>'s "firing submission events" flag #4621

Add <form>'s "firing submission events" flag #4621

Conversation

tkent-google commented May 14, 2019 • edited by pr-preview bot Loading

annevk commented May 14, 2019

domenic left a comment

Choose a reason for hiding this comment

domenic May 14, 2019

Choose a reason for hiding this comment

tkent-google commented May 15, 2019

domenic commented May 15, 2019

tkent-google commented May 15, 2019

domenic commented May 15, 2019

annevk commented May 15, 2019

tkent-google May 15, 2019

Choose a reason for hiding this comment

domenic May 15, 2019

Choose a reason for hiding this comment

tkent-google commented May 14, 2019 •

edited by pr-preview bot

Loading