-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for input and change event properties #24995
Conversation
I see there's just one failure, in Safari: https://wpt.fyi/results/html/semantics/forms/input-change-event-properties.html?sha=4639b08e10&label=pr_head Additional asserts might make it clearer which event didn't fire as expected. |
Hmm, that's probably my bad; I assumed pressing down arrow on a select would be enough to change it in every browser, but that's rather UI dependent. This will be hard to fix without a Mac... |
I made a recording which might help figure out how to make this work on macOS. I clicked the select element with the mouse, then the down arrow only changes the selected option in the popup, it doesn't commit that change. Pressing space does. Maybe sending a down and space key will work? If not then I'm not sure. Is it necessary for the change event to be triggered by use interaction with the form element, or could that one be done programatically? |
Thank you very much!!
From your description, I should send a click first, right?
Yes; programmatic changes do not trigger these events. |
I give up; I can't manage to get Safari to trigger. Maybe it is an actual Safari bug! I'll merge and folks who own Macs can try to fix it... |
See whatwg/html#5453.
I think this is my first testdriver test!