Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire "input" events as composed #5822

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Fire "input" events as composed #5822

merged 2 commits into from
Aug 18, 2020

Conversation

domenic
Copy link
Member

@domenic domenic commented Aug 13, 2020

This is how things have been implemented in all browsers, probably based
off of the definitions in the UI Events specification. See also the
discussion in #5453.

This includes an editorial change to deduplicate some repeated text in
the section.

  • At least two implementers are interested (and none opposed):
    • All implementations behave this way.
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chrome: N/A
    • Firefox: N/A
    • Safari: N/A

(See WHATWG Working Mode: Changes for more details.)


/form-elements.html ( diff )
/infrastructure.html ( diff )
/input.html ( diff )

This is how things have been implemented in all browsers, probably based
off of the definitions in the UI Events specification. See also the
discussion in #5453.

This includes an editorial change to deduplicate some repeated text in
the <input type=file> section.
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. We might want to abstract this into a "fire an input event" thingie. When looking into this I noticed that we don't use the InputEvent class either, yet that is what both Chrome and Firefox implement. So it definitely seems like UI Events is being followed for things it doesn't really specify.

@domenic domenic merged commit b417e88 into master Aug 18, 2020
@domenic domenic deleted the input-event-composed branch August 18, 2020 15:21
@domenic domenic added the topic: shadow Relates to shadow trees (as defined in DOM) label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: events topic: forms topic: shadow Relates to shadow trees (as defined in DOM)
Development

Successfully merging this pull request may close these issues.

2 participants