[url] Add a few url tests to cover cases that were not tested before. #25987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first tests around edge cases of the U_IS_UNICODE_CHAR macro, which my younger and more naive self used until http://trac.webkit.org/r267963 and Chrome seems to do something similar. The second and third test what happens when parsing terminates in the file slash state with relative file URLs with and without windows drive letters, which terminal state I forgot in my initial implementation of file host copying in http://trac.webkit.org/r267896 The last verifies that using a windows drive letter as a relative file URL path removes all of the base URL's path including any drive letter it may have. This is something I was unsure about when implementing r267964 but matches the behavior of IE and Edge.
wpt-pr-bot
requested review from
annevk,
domenic,
GPHemsley,
mikewest and
TimothyGu
domenic
approved these changes
Oct 5, 2020
watilde
added a commit
to watilde/node
that referenced
this pull request
Oct 14, 2020
3 tasks
watilde
added a commit
to nodejs/node
that referenced
this pull request
Oct 16, 2020
Refs: web-platform-tests/wpt#25987 PR-URL: #35636 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first tests around edge cases of the U_IS_UNICODE_CHAR macro,
which my younger and more naive self used until http://trac.webkit.org/r267963
and Chrome seems to do something similar.
The second and third test what happens when parsing terminates in the file slash
state with relative file URLs with and without windows drive letters, which
terminal state I forgot in my initial implementation of file host copying in
http://trac.webkit.org/r267896
The last verifies that using a windows drive letter as a relative file URL path
removes all of the base URL's path including any drive letter it may have.
This is something I was unsure about when implementing r267964 but matches the
behavior of IE and Edge.