Cookies: test non-UTF-8 bytes #26170
Conversation
cookies/resources/bytes.py
Outdated
| response.headers.append(b"Set-Cookie", b"cookiesarebananas=\xFFtest\xFF") | ||
| response.content = "set" | ||
| elif "get" in request.GET: | ||
| response.content = urllib.quote(request.headers["Cookie"]) |
There was a problem hiding this comment.
This will throw in Python 3, since quote lives in urllib.parse now.
I don't even know what the plans are for Python3 and tests, so this may be a non-issue if there is no plan, but something to consider:
try:
from urllib.parse import quote
except ImportError:
from urllib import quoteAnd then calling quote directly.
There was a problem hiding this comment.
Please use from six.moves.urllib.parse import quote :)
EDIT: And yes, new python file handlers should be py3 compatible please (we understand its a bit of a pain since the CI isn't py3 yet). High-level plan is for WPT to go Py3-first in the next few months, and Py3-only sometime around Feb 2021. (But this hasn't been ratified via RFC yet).
There was a problem hiding this comment.
Thanks, I think I'll hold off on merging this pending #26190.
There was a problem hiding this comment.
@annevk I think it's safe to merge now.
There was a problem hiding this comment.
I hadn't made it P3-compatible yet. 😊
I have now, but it also seems like this hasn't been decided by the IETF WG yet.
annevk
force-pushed
the
annevk/cookie-non-utf-8
branch
from
5194de2 to
cdde8ac
Compare
This is for httpwg/http-extensions#1707 I took some inspiration from web-platform-tests#26170 and used a python server instead of a header file in order to better control which bytes are served as part of the header. The test runs exclusively on the élève. subdomain through opening a new window that then runs all test and reports back to the main test window.
This is for httpwg/http-extensions#1707. I took some inspiration from #26170 and used a python server instead of a header file in order to better control which bytes are served as part of the header. The test runs exclusively on the élève. subdomain through opening a new window that then runs all test and reports back to the main test window.
This is for httpwg/http-extensions#1707. I took some inspiration from web-platform-tests#26170 and used a python server instead of a header file in order to better control which bytes are served as part of the header. The test runs exclusively on the élève. subdomain through opening a new window that then runs all test and reports back to the main test window.
This is for httpwg/http-extensions#1707. I took some inspiration from web-platform-tests#26170 and used a python server instead of a header file in order to better control which bytes are served as part of the header. The test runs exclusively on the élève. subdomain through opening a new window that then runs all test and reports back to the main test window.
For httpwg/http-extensions#1073.
I could not find a way to test this using the existing infrastructure (note that
document.cookiedoes not support these kind of values). That might be another thing you want to look at @miketaylr? This approach isn't exactly great, but I wanted to at least capture this nuance somewhere.