Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Taskcluster] pin Chrome Dev to 91.0.4449.6 #28238

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Conversation

foolip
Copy link
Member

@foolip foolip commented Mar 25, 2021

This is a temporary measure while the cause of the crash is being
investigated. This follows a similar approach taken before:
#19360

Mitigation (not fix) for #28209.

This is a temporary measure while the cause of the crash is being
investigated. This follows a similar approach taken before:
#19360

Mitigation (not fix) for #28209.
@foolip foolip force-pushed the foolip/pin-chrome branch from d850859 to 81bd31a Compare March 25, 2021 11:07
@foolip
Copy link
Member Author

foolip commented Mar 25, 2021

Before I merge this I'm going to combine it with a recently blocked PR and see if it works when running some affected tests.

@stephenmcgruer
Copy link
Contributor

I pushed a trigger run of this (at 81bd31a) to chrome_dev, so that should get us a fairly clear picture of whether things are working

@foolip
Copy link
Member Author

foolip commented Mar 25, 2021

@stephenmcgruer do you think we should wait for a full run to finish, or just see that it's in progress?

#28239 has finished wpt-chrome-dev-results which failed on #28237 so I'd be confident enough merging this now.

@stephenmcgruer
Copy link
Contributor

#28239 has finished wpt-chrome-dev-results which failed on #28237 so I'd be confident enough merging this now.

That's good enough for me tbh. A trigger run was probably too much, really 😂

@foolip
Copy link
Member Author

foolip commented Mar 25, 2021

I'll just wait for sink-task to go green before merging this.

foolip added a commit that referenced this pull request Apr 14, 2021
foolip added a commit that referenced this pull request Apr 14, 2021
This reverts #28238.

Update expactations for websockets over h2, which now works.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Apr 24, 2021
…91.0.4449.6", a=testonly

Automatic update from web-platform-tests
Revert "[Taskcluster] pin Chrome Dev to 91.0.4449.6" (#28464)

This reverts web-platform-tests/wpt#28238.

Update expactations for websockets over h2, which now works.
--

wpt-commits: e2fe814ee728461bf4f14f5b8b705c565c48bd1c
wpt-pr: 28464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants