Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing assert_equals #28226

Merged
merged 1 commit into from
Apr 6, 2021
Merged

Fix missing assert_equals #28226

merged 1 commit into from
Apr 6, 2021

Conversation

TRowbotham
Copy link
Contributor

Node-contains-xml.xml#L58 calls document.contains() with 3 args, which isn't correct. Presumably, the author intended to call assert_equals().

@wpt-pr-bot wpt-pr-bot added the dom label Mar 24, 2021
@wpt-pr-bot wpt-pr-bot requested review from annevk, jdm and zqzhang March 24, 2021 19:32
@annevk
Copy link
Member

annevk commented Mar 25, 2021

Landing this is blocked on #28209 it seems.

@foolip
Copy link
Member

foolip commented Mar 25, 2021

The wpt-chrome-dev-* CI failures here were likely due to #19360. A workaround was landed in #28238, so I'm closing and reopening to re-trigger the CI checks.

@foolip foolip closed this Mar 25, 2021
@foolip foolip reopened this Mar 25, 2021
@gsnedders gsnedders merged commit a13852d into web-platform-tests:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@jdm jdm Awaiting requested review from jdm

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees

@zqzhang zqzhang

Labels
dom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TRowbotham @annevk @foolip @gsnedders @zqzhang @wpt-pr-bot