-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP/2fy request-upload test around streaming #28236
HTTP/2fy request-upload test around streaming #28236
Conversation
I guess we haven't quite resolved whether to support H/1, but ideally we have some kind of test for that as well. |
Yes but supporting H/2 has been decided. Should we also have a wpt that confirms the feature is not supported over H/1? |
Undid confirming failure tests, which required wptserve/wptserve/server.py change. Will do later-on. |
Ping? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@yoichio I'm not sure I understand your comment above. Has there been a decision to only support H/2 and up? If so, a test or a few tests for non-support for H/1 would be great. (To be clear, that shouldn't be a blocker to landing this PR.) |
No to "only" but yes to supporting at least H/2.
That's bit confusing. Should we put a wpt test that points an API doesn't work? This is different from how an API raises an exception. |
I'm O.K to just put same tests both in request-upload.any.js and request-upload.h2.any.js |
All I'm saying is that once we make a decision on what to do for H/1 we should have test coverage for that decision. |
Sure. |
Ping? |
@yoichio you should feel free to merge this. Or do you want another review? |
I don't have a write access to this repository. |
(I've asked on W3C IRC |
That's because wpt h1 server doesn't support chunked encoding but h2 supports it natively.
Related thread: whatwg/fetch#966