Don't expect newline normalizations when constructing the entry list #28798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests the spec changes in whatwg/html#6624, as well as the textarea cases to be covered in a follow-up spec PR.
wpt-pr-bot
requested review from
annevk,
caitp,
domenic,
foolip,
jdm,
jgraham,
Manishearth,
tkent-google,
wisniewskit and
zqzhang
annevk
reviewed
May 4, 2021
3 tasks
|
Since the decision to normalize textareas to LF has now been taken, and the corresponding PR is now open at whatwg/html#6697, it seems like this can now be merged with no further changes. |
annevk
approved these changes
May 20, 2021
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 20, 2021
As of #6287 newlines are normalized when form data is serialized. This removes the (mostly redundant) normalization in constructing the entry list. Tests: web-platform-tests/wpt#28798. Follow-up: #6697. Fixes #6469.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the spec changes in whatwg/html#6624, as well as the
<textarea>cases to be covered in a follow-up spec PR (#6697).