Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expect newline normalizations when constructing the entry list #28798

Merged
merged 3 commits into from
May 20, 2021
Merged

Don't expect newline normalizations when constructing the entry list #28798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9a0ea
Don't expect newline normalizations when constructing the entry list
May 3, 2021
907071b
fix lint
May 3, 2021
752bd8b
Moving the textarea wrapping transformation tests to the textarea ele…
May 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions html/semantics/forms/form-submission-0/newline-normalization.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
<html>
<head>
<meta charset="utf-8" />
<title>Form newline normalization</title>
<title>
Constructing the entry list shouldn't perform newline normalization
</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
</head>
Expand Down Expand Up @@ -40,71 +42,71 @@

test((testCase) => {
const formData = new FormData(createForm(testCase, "a", "b\nc"));
assert_equals(formData.get("a"), "b\r\nc");
}, document.title + ": \\n in the value becomes \\r\\n");
assert_equals(formData.get("a"), "b\nc");
}, document.title + ": \\n in the value");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a", "b\rc"));
assert_equals(formData.get("a"), "b\r\nc");
}, document.title + ": \\r in the value becomes \\r\\n");
assert_equals(formData.get("a"), "b\rc");
}, document.title + ": \\r in the value");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a", "b\r\nc"));
assert_equals(formData.get("a"), "b\r\nc");
}, document.title + ": \\r\\n in the value stays unchanged");
}, document.title + ": \\r\\n in the value");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a", "b\n\rc"));
assert_equals(formData.get("a"), "b\r\n\r\nc");
}, document.title + ": \\n\\r in the value becomes \\r\\n\\r\\n");
assert_equals(formData.get("a"), "b\n\rc");
}, document.title + ": \\n\\r in the value");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a\nb", "c"));
assert_equals([...formData][0][0], "a\r\nb");
}, document.title + ": \\n in the name becomes \\r\\n");
assert_equals([...formData][0][0], "a\nb");
}, document.title + ": \\n in the name");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a\rb", "c"));
assert_equals([...formData][0][0], "a\r\nb");
}, document.title + ": \\r in the name becomes \\r\\n");
assert_equals([...formData][0][0], "a\rb");
}, document.title + ": \\r in the name");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a\r\nb", "c"));
assert_equals([...formData][0][0], "a\r\nb");
}, document.title + ": \\r\\n in the name stays unchanged");
}, document.title + ": \\r\\n in the name");

test((testCase) => {
const formData = new FormData(createForm(testCase, "a\n\rb", "c"));
assert_equals([...formData][0][0], "a\r\n\r\nb");
}, document.title + ": \\n\\r in the name becomes \\r\\n\\r\\n");
assert_equals([...formData][0][0], "a\n\rb");
}, document.title + ": \\n\\r in the name");

test((testCase) => {
const formData = new FormData(
createFormWithFile(testCase, "a", "b\nc")
);
assert_equals(formData.get("a").name, "b\nc");
}, document.title + ": \\n in the filename stays unchanged");
}, document.title + ": \\n in the filename");

test((testCase) => {
const formData = new FormData(
createFormWithFile(testCase, "a", "b\rc")
);
assert_equals(formData.get("a").name, "b\rc");
}, document.title + ": \\r in the filename stays unchanged");
}, document.title + ": \\r in the filename");

test((testCase) => {
const formData = new FormData(
createFormWithFile(testCase, "a", "b\r\nc")
);
assert_equals(formData.get("a").name, "b\r\nc");
}, document.title + ": \\r\\n in the filename stays unchanged");
}, document.title + ": \\r\\n in the filename");

test((testCase) => {
const formData = new FormData(
createFormWithFile(testCase, "a", "b\n\rc")
);
assert_equals(formData.get("a").name, "b\n\rc");
}, document.title + ": \\n\\r in the filename stays unchanged");
}, document.title + ": \\n\\r in the filename");
</script>
</body>
</html>
58 changes: 58 additions & 0 deletions html/semantics/forms/the-textarea-element/wrapping-transformation.window.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
test((t) => {
const form = document.createElement("form");
const textarea = document.createElement("textarea");
textarea.name = "linebreakTest";
textarea.textContent = "a\nb\rc\r\nd\n\re";
form.appendChild(textarea);
document.body.appendChild(form);
t.add_cleanup(() => {
document.body.removeChild(form);
});

assert_equals(textarea.textContent, "a\nb\rc\r\nd\n\re");
assert_equals(textarea.value, "a\nb\nc\nd\n\ne");

const formData = new FormData(form);
assert_equals(
formData.get("linebreakTest"),
"a\nb\nc\nd\n\ne",
);
}, "Textarea wrapping transformation: Newlines should be normalized to LF.");

test((t) => {
const form = document.createElement("form");
const textarea = document.createElement("textarea");
textarea.name = "wrapTest";
textarea.cols = 10;
textarea.wrap = "hard";
textarea.textContent =
"Some text that is too long for the specified character width.";
form.appendChild(textarea);
document.body.appendChild(form);
t.add_cleanup(() => {
document.body.removeChild(form);
});

assert_true(
!textarea.textContent.includes("\n") &&
!textarea.textContent.includes("\r"),
"textContent shouldn't contain any newlines",
);
assert_true(
!textarea.textContent.includes("\n") &&
!textarea.textContent.includes("\r"),
"The API value shouldn't be line wrapped.",
);

const formData = new FormData(form);
const formDataValue = formData.get("wrapTest");

assert_true(
!formDataValue.includes("\r"),
"The wrapping done on the value must be LF, not CRLF.",
);
assert_true(
formDataValue.includes("\n"),
"The value must be wrapped.",
);
}, "Textarea wrapping transformation: Wrapping happens with LF newlines.");
6 changes: 3 additions & 3 deletions xhr/formdata/constructor-formelement.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
<input type="color" name="submit-me-15" value="#123456">

<textarea name="submit-me-16">textarea value
with linebreaks set to CRLF</textarea>
with linebreaks set to LF</textarea>

<!-- this generates two form data entries! -->
<input type="text" name="dirname-is-special" dirname="submit-me-17" value="dirname-value">
Expand Down Expand Up @@ -123,11 +123,11 @@
["submit-me-13", "11"],
["submit-me-14", "11"],
["submit-me-15", "#123456"],
["submit-me-16", "textarea value\r\nwith linebreaks set to CRLF"],
["submit-me-16", "textarea value\nwith linebreaks set to LF"],
["dirname-is-special", "dirname-value"],
["submit-me-17", "ltr"],
["submit-me-18-\uFFFD", "value-\uFFFD"],
["submit-me-\r\n19\r\n", "value"],
["submit-me-\r19\n", "value"],
["submit-me-21", ""]
];

Expand Down