Modify errors from try server, #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MozReview-Commit-ID: KEayE2B7aKX Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1323916
MozReview-Commit-ID: 60HmJf3G2CR Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1286150
Blink and webkit launch focusin after focus and focusout after blur. Despite this contradiction with the spec, it is best to mirror this new way, as there is little guidance or existing code to clarify implementation amiguities that can arise from the spec. If focus/blur is fired on a window or document, or the event triggers a change of focus, do not fire the corresponding focusin/focusout. Otherwise, always fire the corresponding event. Additionally, add a mochitest and a w3c-platform-test. MozReview-Commit-ID: AgQ8JBxKIqK Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=687787
…ipted change). Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1313254
…kground thread and the Connection thread. Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1309527
From the Segment Parser Loop definition: https://w3c.github.io/media-source/index.html#sourcebuffer-segment-parser-loop "2. If the input buffer contains bytes that violate the SourceBuffer byte stream format specification, then run the append error algorithm and abort this algorithm." The test appends data with a valid init segment followed by corrupted content. The corrupted content satisfies the condition that the input buffer contains bytes that violate byte stream format specification. As such, the append error algorithm is to be run prior parsing the init segment. Add a new test verifying the defined behavior. Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1314533
MozReview-Commit-ID: 1hFdxbHAwmB Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1273784
|
Code reviewed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=976073