Update cookie-related OWNERS and READMEs #7531
Conversation
|
There are no owners for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
|
@mikewest, what would be some other good owners for this? Can you add a README.md explaining which specs this covers? Is it just https://w3c.github.io/webappsec-csp/cookies/, or also https://tools.ietf.org/html/rfc6265? Finally, I noticed that #4423 deleted some of your tests. Did you know, and is that OK? If it's not OK, then @Hexcles or I should do some kind of audit for tests that we've exported and then had removed. |
Build PASSEDStarted: 2017-11-16 22:53:25 View more information about this build on: |
|
#4423 is a Gecko export of https://bugzilla.mozilla.org/show_bug.cgi?id=976073. Looks like the tests were deleted unintentionally and later restored in https://bugzilla.mozilla.org/show_bug.cgi?id=1316532, which was not upstreamed. Could you take a look @jgraham ? |
|
@Hexcles, @jgraham is away during October, so I guess we'll need to fix this. Maybe noticing this kind of thing could be part of the audit script, where if files we've exported are deleted by something other than a new export are flagged for review. Most will be fine, but some might be accidents. For now I'll revert the files back into existence. |
This reverts commit 05e8454. This appears to have been an accident, see #7531 (comment)
This reverts commit 05e8454. This appears to have been an accident, see #7531 (comment)
|
Now I'm also wondering about the relationship between this and cookie-store/. @bsittler, do you know? |
|
These appear to be tests (originally by @tefn3849 I believe - are you a suitable owner?) verifying behavior specified in https://datatracker.ietf.org/doc/draft-ietf-httpbis-cookie-alone/ by @mikewest It bears only tangential relationship to the https://github.com/WICG/cookie-store proposal is that the latter (a proposed new JS API for cookie operations) mentions enforcing the restrictions of the former too, in that case with promise rejections when non-conforming operations are attempted. |
|
This is a wild guess, but perhaps @annevk could knows of a suitable owner for these tests? |
|
I would have suggested @bsittler and @mikewest... At some point @inikulin was interested (see whatwg/html#804), but not sure if that's still the case. |
|
I always willing to help. What are duties with this one? |
|
FWIW I am also willing to help, but like @inikulin I would like to understand what's involved. I actually misunderstood earlier and thought you were asking about who wrote the tests |
|
/cc @pwnall in case interested |
|
@foolip I can help, sign me up. I skimmed through the tests. I'm reasonably familiar with the matter, having read the relevant RFCs in order to implement Chrome's Async Cookies API. I also had to / will have to write or review similar tests for Async Cookies. |
foolip
force-pushed
the
cookies-owners
branch
from
c332eab to
145d223
Compare
foolip
changed the title
| @@ -0,0 +1,2 @@ | |||
| This directory contains tests for | |||
| [Leave Secure Cookies Alone](https://tools.ietf.org/html/draft-ietf-httpbis-cookie-alone-01). | |||
There was a problem hiding this comment.
Seems like https://github.com/w3c/web-platform-tests/blob/master/cookies/path/match.html covers a bit more than the IETF draft you linked. I think this is a reasonable first step and we can rely on @mikewest's guidance for the next step 😸
|
I was imagining that we'd eventually migrate the IETF test suite for the cookies RFC into this repository as part of putting together RFC6265bis. I am astoundingly slow at that (and it's currently impossible to test |
This reverts commit 05e8454. This appears to have been an accident, see web-platform-tests#7531 (comment)
No description provided.