WebNN: Remove argmin/max selectLastIndex parameter #47166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5700708
branch
2 times, most recently
from
6dbe9df to
c2f939e
Compare
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5700708
branch
from
c2f939e to
6cf698b
Compare
wpt-pr-bot
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL removes the selectLastIndex parameter from argMin and argMax to
align with the spec change [1].
The changes include the definition of IDL and mojo, the implementation
of DirectML and TfLite backend and the related unit tests and WPT tests.
[1] webmachinelearning/webnn#722
Bug: 352314071, 40206287
Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708
Reviewed-by: Phillis Tang <phillis@chromium.org>
Reviewed-by: Elly FJ <ellyjones@chromium.org>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Bin Miao <bin.miao@intel.com>
Cr-Commit-Position: refs/heads/main@{#1328688}