Remove argmin/max selectLastIndex parameter #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Jul 12, 2024
SHA: af67a72 Reason: push, by huningxin Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 16, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 17, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 17, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jul 17, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 17, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 17, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jul 18, 2024
… parameter, a=testonly Automatic update from web-platform-tests WebNN: Remove argmin/max selectLastIndex parameter This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688} -- wpt-commits: 40e2956b57dcb5598df544e6894de37a5ae7c16a wpt-pr: 47166
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jul 20, 2024
… parameter, a=testonly Automatic update from web-platform-tests WebNN: Remove argmin/max selectLastIndex parameter This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688} -- wpt-commits: 40e2956b57dcb5598df544e6894de37a5ae7c16a wpt-pr: 47166
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 22, 2024
This CL removes the selectLastIndex parameter from argMin and argMax to align with the spec change [1]. The changes include the definition of IDL and mojo, the implementation of DirectML and TfLite backend and the related unit tests and WPT tests. [1] webmachinelearning/webnn#722 Bug: 352314071, 40206287 Change-Id: Ifbb1c5b8c5eef41f87b279c2b1018d2d5d0198ea Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14.arm64-blink-rel,mac14-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5700708 Reviewed-by: Phillis Tang <phillis@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Bin Miao <bin.miao@intel.com> Cr-Commit-Position: refs/heads/main@{#1328688}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #652
This removes the
selectLastIndexparameter from argMin and argMax, given that the CoreML backend has no guarantee of return value in case of ties.@fdwr please take a look :)
Preview | Diff