Move 'valid codec with spaces' to validButUnsupportedConfigs configs #48870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UA is not expected to support codec strings with whitespaces around it, even though it's a valid config.
padenot
approved these changes
Nov 18, 2024
moz-wptsync-bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
Previously, codec strings containing spaces were trimmed, and VideoDecoder would report them as "supported". However, per changes introduced in PR #48870 [1], such codec strings, while "valid" in terms of syntax, should be considered "unsupported" by the VideoDecoder. Given that codec strings with spaces should be marked as "unsupported", it's unnecessary to parse these codec strings before checking if they are supported video codecs. The underlying checking method reports codec strings containing spaces as "unsupported", naturally aligning with the expected behavior. [1] #48870 Differential Revision: https://phabricator.services.mozilla.com/D231716 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827 gecko-commit: 375d118ff39a50118a2fa26b3892d81da6f327a8 gecko-reviewers: media-playback-reviewers, alwu
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 24, 2024
… spaces r=media-playback-reviewers,alwu Previously, codec strings containing spaces were trimmed, and VideoDecoder would report them as "supported". However, per changes introduced in PR #48870 [1], such codec strings, while "valid" in terms of syntax, should be considered "unsupported" by the VideoDecoder. Given that codec strings with spaces should be marked as "unsupported", it's unnecessary to parse these codec strings before checking if they are supported video codecs. The underlying checking method reports codec strings containing spaces as "unsupported", naturally aligning with the expected behavior. [1] web-platform-tests/wpt#48870 Differential Revision: https://phabricator.services.mozilla.com/D231716
moz-wptsync-bot
pushed a commit
that referenced
this pull request
Dec 24, 2024
Previously, codec strings containing spaces were trimmed, and VideoDecoder would report them as "supported". However, per changes introduced in PR #48870 [1], such codec strings, while "valid" in terms of syntax, should be considered "unsupported" by the VideoDecoder. Given that codec strings with spaces should be marked as "unsupported", it's unnecessary to parse these codec strings before checking if they are supported video codecs. The underlying checking method reports codec strings containing spaces as "unsupported", naturally aligning with the expected behavior. [1] #48870 Differential Revision: https://phabricator.services.mozilla.com/D231716 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827 gecko-commit: 375d118ff39a50118a2fa26b3892d81da6f327a8 gecko-reviewers: media-playback-reviewers, alwu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UA is not expected to support codec strings with whitespaces around it, even though it's a valid config.
Originally when this test was introduced by 10ae579 , it tested that spaces around codec string don't make it invalid. Later on this 3939cbf change started to check that
' vp09.00.10.08 'is a correct way to refer to a VP9 codec andVideoDecoder.configure()should be succeed. The spec does not support this point of view and I see no reason to allow it.