[Gecko Bug 1931827] VideoDecoder: Return unsupported for codec strings with spaces #49827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, codec strings containing spaces were trimmed, and VideoDecoder would report them as "supported". However, per changes introduced in PR #48870 [1], such codec strings, while "valid" in terms of syntax, should be considered "unsupported" by the VideoDecoder. Given that codec strings with spaces should be marked as "unsupported", it's unnecessary to parse these codec strings before checking if they are supported video codecs. The underlying checking method reports codec strings containing spaces as "unsupported", naturally aligning with the expected behavior. [1] #48870 Differential Revision: https://phabricator.services.mozilla.com/D231716 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827 gecko-commit: 375d118ff39a50118a2fa26b3892d81da6f327a8 gecko-reviewers: media-playback-reviewers, alwu
This patch updates AudioDecoder to return "unsupported" for codec strings containing spaces, consistent with the approach taken in the preceding patch. As part of this update, the `AudioMIMECreateParam` class is removed since there is no longer a need to trim spaces from codec strings. Any codec string containing spaces is immediately considered "unsupported". Additionally, this patch adds a WPT to verify that AudioDecoder correctly returns "unsupported" for codec strings with spaces, ensuring the decoder behaves as expected. Differential Revision: https://phabricator.services.mozilla.com/D231717 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827 gecko-commit: b28767c670a7bb8d22744d3586b7bac7ef73d785 gecko-reviewers: media-playback-reviewers, alwu
This patch updates AudioEncoder to return "unsupported" for codec strings containing spaces, consistent with the approach taken in the preceding patch. By moving `IsSupportedAudioCodec` to `CanEncode` and removing the unnecessary codec string trimming, AudioEncoder now behaves as expected since codec string with spaces fails to pass `IsSupportedAudioCodec`'s check. A WPT is also added to verify that AudioEncoder returns "unsupported" when passing codec strings that contains spaces to `IsConfigSupported` or `configure`. Differential Revision: https://phabricator.services.mozilla.com/D231718 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827 gecko-commit: 709c474955599eed0ae62f9d8815b517c7d1cf07 gecko-reviewers: media-playback-reviewers, alwu
wpt-pr-bot
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, codec strings containing spaces were trimmed, and
VideoDecoder would report them as "supported". However, per changes
introduced in PR #48870 [1], such codec strings, while "valid" in terms
of syntax, should be considered "unsupported" by the VideoDecoder.
Given that codec strings with spaces should be marked as "unsupported",
it's unnecessary to parse these codec strings before checking if they
are supported video codecs. The underlying checking method reports codec
strings containing spaces as "unsupported", naturally aligning with the
expected behavior.
[1] #48870
Differential Revision: https://phabricator.services.mozilla.com/D231716
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1931827
gecko-commit: 375d118ff39a50118a2fa26b3892d81da6f327a8
gecko-reviewers: media-playback-reviewers, alwu