-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tentative: match new PR about 2E "unless the element is marked as presentational" #50002
base: master
Are you sure you want to change the base?
Conversation
<h2>HTML input with role="none" and label associated (presentational roles conflict resolution)</h2> | ||
<h3>HTML input label/for</h3> | ||
<label for="irn">input label</label> | ||
<input id="irn" type="text" data-expectedlabel="input label" data-testname="html: label[for]input[role presentation]" class="ex" role="presentation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @giacomo-petri, should the input here have a role="none"
or are you using role="presentation"
interchangeably?
<h2>HTML input with role="none" and label with role presentation (presentational roles conflict resolution)</h2> | ||
<h3>HTML input label/for</h3> | ||
<label role="presentation" for="lirp">input label</label> | ||
<input id="lirp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role presentation] input[role presentation]" class="ex" role="presentation"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above. The heading indicates this is testing for a label with role="presentation"
and input with role="none"
but the input here is role="presentation"
.
Hi @giacomo-petri, I'm coming from the review of PR 2405. This looks good to me for the most part, Scott's addressed some of the initial confusion. I noted some semantic confusion in the naming of the test sections vs what is being tested. While Unless there's something I'm missing, the heading and test setup should match to avoid confusion for folks when reading. Thank you for this work! |
Done |
Thanks @giacomo-petri! You have some lint errors, once you've addressed those I'll be happy to approve this. |
Closes: web-platform-tests/interop-accessibility#167
Relates and match: w3c/aria#2405
Ambiguity: https://www.w3.org/TR/accname-1.2/#comp_host_language_label
This PR adds tests for:
Note: since I created tests for acc name related to presentational roles conflict resolution, I have also included tests to verify that the computed role aligns with the expected result.