Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+114 −0
Open

Tentative: match new PR about 2E "unless the element is marked as presentational" #50002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
43184ee
Acc test for input with acc name coming from label elements with role…
giacomo-petri Jan 9, 2025
8fdb651
Update comp_host_language_label.tentative.html
giacomo-petri Jan 9, 2025
28d3673
Update comp_host_language_label.tentative.html
giacomo-petri Jan 11, 2025
0af612d
Create role_none_conflict_resolution.tentative.html
giacomo-petri Jan 11, 2025
84dddad
Update comp_host_language_label.tentative.html
giacomo-petri Jan 13, 2025
828fd3c
Update role_none_conflict_resolution.tentative.html
giacomo-petri Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 86 additions & 0 deletions accname/name/comp_host_language_label.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
<!doctype html>
<html>
<head>
<title>Name Comp: Host Language Label</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/wai-aria/scripts/aria-utils.js"></script>
</head>
<body>
<!-- Ambiguity coming from Host Language Label in accname specs (https://www.w3.org/TR/accname-1.2/#comp_host_language_label) - PR that tries to solve it https://github.com/w3c/aria/pull/2405 -->
<h2>HTML input with label with role presentation</h2>
<h3>HTML input label/for</h3>
<label role="presentation" for="lrp">input label</label>
<input id="lrp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role presentation]" class="ex">
<h3>HTML label encapsulation</h3>
<label role="presentation">
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: label[role presentation] encapsulation" class="ex">
</label>

<h2>HTML input with role="presentation" and label associated (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label for="irn">input label</label>
<input id="irn" type="text" data-expectedlabel="input label" data-testname="html: label[for]input[role presentation]" class="ex" role="presentation">
Copy link

@lolaodelola lolaodelola Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @giacomo-petri, should the input here have a role="none" or are you using role="presentation" interchangeably?

<h3>HTML label encapsulation</h3>
<label>
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: input[role presentation] with label encapsulation" class="ex" role="presentation">
</label>

<h2>HTML input with role="presentation" and label with role presentation (presentational roles conflict resolution)</h2>
<h3>HTML input label/for</h3>
<label role="presentation" for="lirp">input label</label>
<input id="lirp" type="text" data-expectedlabel="input label" data-testname="html: label[for][role presentation] input[role presentation]" class="ex" role="presentation">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above. The heading indicates this is testing for a label with role="presentation" and input with role="none" but the input here is role="presentation".

<h3>HTML label encapsulation</h3>
<label role="presentation">
<span>input label</span>
<input type="text" data-expectedlabel="input label" data-testname="html: input[role presentation] with label[role presentation] encapsulation" class="ex" role="presentation">
</label>

<h2>HTML input with role="presentation" and disabled with label associated</h2>
<h3>HTML input label/for</h3>
<label for="irpd">input label</label>
<input id="irpd" type="text" data-expectedlabel="" data-testname="html: label[for]input[role presentation][disabled]" class="ex" role="presentation" disabled>
<h3>HTML label encapsulation</h3>
<label>
<span>input label</span>
<input type="text" data-expectedlabel="" data-testname="html: input[role presentation][disabled] with label encapsulation" class="ex" role="presentation" disabled>
</label>

<h2>HTML img with role="presentation" and non empty alt</h2>
<img src="https://www.w3.org/assets/logos/w3c/w3c-no-bars.svg" role="presentation" alt="w3c logo" data-expectedlabel="" data-testname="html: img[role presentation][non-empty alt]">

<h2>SVG wrapping title with role="presentation"</h2>
<svg viewBox="0 0 20 10" xmlns="http://www.w3.org/2000/svg" data-expectedlabel="circle" data-testname="svg: svg wrapping title[role presentation]">
<circle cx="5" cy="5" r="4">
<title role="presentation">circle</title>
</circle>
</svg>

<h2>HTML fieldset wrapping legend with role="presentation"</h2>
<fieldset data-expectedlabel="legend" data-testname="html: fieldset wrapping legend[role presentation]"><legend role="presentation">legend</legend></fieldset>

<h2>HTML fieldset with role="presentation" wrapping legend</h2>
<fieldset role="presentation" data-expectedlabel="" data-testname="html: fieldset[role presentation] wrapping legend"><legend>legend</legend></fieldset>

<h2>HTML fieldset role="presentation" wrapping legend with role="presentation"</h2>
<fieldset role="presentation" data-expectedlabel="" data-testname="html: fieldset[role presentation] wrapping legend[role presentation]"><legend role="presentation">legend</legend></fieldset>

<h2>HTML table wrapping caption with role="presentation"</h2>
<table data-expectedlabel="caption" data-testname="html: table wrapping caption[role presentation]"><caption role="presentation">caption</caption></table>

<h2>HTML table with role="presentation" wrapping caption</h2>
<table role="presentation" data-expectedlabel="" data-testname="html: table[role presentation] wrapping caption"><caption>caption</caption></table>

<h2>HTML table role="presentation" wrapping caption with role="presentation"</h2>
<table role="presentation" data-expectedlabel="" data-testname="html: table[role presentation] wrapping caption[role presentation]"><caption role="presentation">caption</caption></table>

<script>
AriaUtils.verifyLabelsBySelector(".ex");
</script>
</body>
</html>
28 changes: 28 additions & 0 deletions wai-aria/role/role_none_conflict_resolution.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<!doctype html>
<html>
<head>
<title>Role None/Presentation Conflict Resolution Verification Tests</title>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/resources/testdriver.js"></script>
<script src="/resources/testdriver-vendor.js"></script>
<script src="/resources/testdriver-actions.js"></script>
<script src="/wai-aria/scripts/aria-utils.js"></script>
</head>
<body>

<h2>HTML input with role="presentation" (presentational roles conflict resolution)</h2>
<label for="irn">input label</label>
<input id="irn" type="text" data-expectedrole="textbox" data-testname="HTML input[role presentation] but focusable" class="ex" role="presentation">

<h2>HTML input with role="presentation" and disabled (presentational roles conflict resolution does not apply due to disabled attr)</h2>
<label for="irpd">input label</label>
<input id="irpd" type="text" data-testname="HTML input[role presentation][disabled]" class="ex-generic" role="presentation" disabled>

<script>
AriaUtils.verifyRolesBySelector(".ex");
AriaUtils.verifyGenericRolesBySelector(".ex-generic");
</script>

</body>
</html>