Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<a>, <area>, and <link> must have an active document check #5758

Merged
merged 1 commit into from
Aug 20, 2017

Conversation

annevk
Copy link
Member

@annevk annevk commented May 2, 2017

This change is Reviewable

@wpt-pr-bot
Copy link
Collaborator

Notifying @ayg. (Learn how reviewing works.)

@wpt-pr-bot wpt-pr-bot added the html label May 2, 2017
@ghost
Copy link

ghost commented May 2, 2017

These tests are now available on w3c-test.org

@ghost
Copy link

ghost commented May 2, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 968cf2e
Using browser at version BuildID 20170501100238; SourceStamp 076a7a66096f9e8d102548397254be32eb26bc3d
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/links/following-hyperlinks/active-document.window.html
Subtest Results Messages
OK
<a> in navigated away <iframe>'s document cannot follow hyperlinks PASS
<area> in navigated away <iframe>'s document cannot follow hyperlinks PASS
<link> in navigated away <iframe>'s document cannot follow hyperlinks PASS

@ghost
Copy link

ghost commented May 2, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 968cf2e
Using browser at version 60.0.3080.5 dev
Starting 10 test iterations
All results were stable

All results

1 test ran
/html/semantics/links/following-hyperlinks/active-document.window.html
Subtest Results Messages
OK
<a> in navigated away <iframe>'s document cannot follow hyperlinks PASS
<area> in navigated away <iframe>'s document cannot follow hyperlinks PASS
<link> in navigated away <iframe>'s document cannot follow hyperlinks PASS

@annevk annevk requested a review from domenic May 2, 2017 14:26
annevk added a commit to whatwg/html that referenced this pull request May 3, 2017
Require that they are all connected to a document that is fully
active. There is enough difference between implementations that this
appears to be web compatible.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes #2615.
annevk added a commit to whatwg/html that referenced this pull request May 9, 2017
Require that they are all connected to a document that is fully
active. There is enough difference between implementations that this
appears to be web compatible.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes #2615.
@ayg ayg merged commit 64bfe4e into master Aug 20, 2017
@annevk annevk deleted the annevk/a-area-link-navigate branch August 21, 2017 12:12
annevk added a commit to whatwg/html that referenced this pull request Aug 23, 2017
Require that they are all connected to a document that is fully
active. There is enough difference between implementations that this
appears to be web compatible.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes #2615.
annevk added a commit to whatwg/html that referenced this pull request Sep 22, 2017
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible.

Also perform a second connected check for <form>.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes #2615 and fixes #2708.
rachelandrew pushed a commit to rachelandrew/web-platform-tests that referenced this pull request Nov 8, 2017
alice pushed a commit to alice/html that referenced this pull request Jan 8, 2019
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible.

Also perform a second connected check for <form>.

Tests:

* web-platform-tests/wpt#5758
* web-platform-tests/wpt#5759
* web-platform-tests/wpt#5761

Fixes whatwg#2615 and fixes whatwg#2708.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants