<form> submission checks #5761
Merged
<form> submission checks #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple tests for #3109 and whatwg/html#2615.
|
Notifying @ayg. (Learn how reviewing works.) |
|
These tests are now available on w3c-test.org |
Firefox (nightly channel)Testing web-platform-tests at revision 3ea8c23 All results1 test ran/html/semantics/forms/form-submission-0/submission-checks.window.html
|
Chrome (unstable channel)Testing web-platform-tests at revision 3ea8c23 All results1 test ran/html/semantics/forms/form-submission-0/submission-checks.window.html
|
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 3, 2017
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
annevk
added a commit
to whatwg/html
that referenced
this pull request
May 9, 2017
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
|
Is this just waiting on a reviewer? |
jdm
reviewed
Jul 5, 2017
| frame.onload = t.step_func(() => { | ||
| if(frame.contentWindow.location.href === "about:blank") | ||
| return; | ||
| assert_unreached(); |
There was a problem hiding this comment.
So the origial navigation to /common/blank.html is expected to be interrupted but the disconnected form submission, but that submission should not actually cause any other navigation to occur either?
There was a problem hiding this comment.
There's only a single potential navigation here. And it would be due to the form submission, except it shouldn't work as the form is not connected.
jdm
approved these changes
Jul 5, 2017
annevk
added a commit
to whatwg/html
that referenced
this pull request
Aug 23, 2017
Require that they are all connected to a document that is fully active. There is enough difference between implementations that this appears to be web compatible. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615.
Build PASSEDStarted: 2017-09-15 13:32:57 View more information about this build on: |
domenic
approved these changes
Sep 22, 2017
annevk
added a commit
to whatwg/html
that referenced
this pull request
Sep 22, 2017
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible. Also perform a second connected check for <form>. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes #2615 and fixes #2708.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
Require that they are all connected to a document (except for <a>) that is fully active (including <a>). There is enough difference between implementations that this appears to be web compatible. Also perform a second connected check for <form>. Tests: * web-platform-tests/wpt#5758 * web-platform-tests/wpt#5759 * web-platform-tests/wpt#5761 Fixes whatwg#2615 and fixes whatwg#2708.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple tests for #3109 and whatwg/html#2615.