Merge pull request #233 from web-vision/stefan-2

[TASK] Avoid `rowCount()` for select query
web-vision · May 15, 2023 · 643ced1 · 643ced1
2 parents 1a76a44 + eea7bb8
commit 643ced1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/Classes/Upgrades/GlossaryUpgradeWizard.php b/Classes/Upgrades/GlossaryUpgradeWizard.php
@@ -226,11 +226,13 @@ public function updateNecessary(): bool
  $queryBuilder = GeneralUtility::makeInstance(ConnectionPool::class)
  ->getQueryBuilderForTable('tx_wvdeepltranslate_domain_model_glossaries');
  $queryBuilder->getRestrictions()->removeAll();
- $statement = $queryBuilder
- ->select('*')
- ->from('tx_wvdeepltranslate_domain_model_glossaries');
+ $count = (int)$queryBuilder
+ ->count('*')
+ ->from('tx_wvdeepltranslate_domain_model_glossaries')
+ ->execute()
+ ->fetchColumn(0);
 
- return $statement->execute()->rowCount() > 0;
+ return $count > 0;
  }
 
  /**