[TASK] Avoid rowCount() for select query
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `rowCount(` method for an `SELECT` query is not reliable. That's already documented in the TYPO3 documentation. It's recommended to use a `COUNT()` query instead. See: https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/Database/Statement/Index.html#rowcount This change uses now a `COUNT(*)` based query to avoid the unreliable `rowCount()` method in the corresponding `WebVision\WvDeepltranslate\Upgrades\GlossaryUpgradeWizard`. This will be fixed in main within other stuffs and this is only the manual backport for the 3.x branch. Releases: 3.x
calien666
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
rowCount(method for anSELECTqueryis not reliable. That's already documented in the
TYPO3 documentation. It's recommended to use a
COUNT()query instead.
See: https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/Database/Statement/Index.html#rowcount
This change uses now a
COUNT(*)based query to avoidthe unreliable
rowCount()method in the correspondingWebVision\WvDeepltranslate\Upgrades\GlossaryUpgradeWizard.This will be fixed in main within other stuffs and this
is only the manual backport for the 3.x branch.
Releases: 3.x