Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension breaks installation in non-Composer mode #170

Closed
andreaskienast opened this issue Mar 19, 2023 · 0 comments · Fixed by #171
Closed

Extension breaks installation in non-Composer mode #170

andreaskienast opened this issue Mar 19, 2023 · 0 comments · Fixed by #171

Comments

@andreaskienast
Copy link
Contributor

The extension claims to be compatible with TYPO3 10.4, which is unfortunately not completely true. If TYPO3 10.4 is run with PHP 7.2 (yeah yeah, I know...), using this extension breaks the installation as code is used that doesn't work with PHP 7.2 (e.g. null coalesce assignment operators).

This is only an issue when TYPO3 isn't installed via Composer, as the PHP version constraint is missing in ext_emconf.php.
andreaskienast added a commit to andreaskienast/wv_deepltranslate that referenced this issue Mar 19, 2023
@andreaskienast
[BUGFIX] Require PHP version in ext_emconf.php
7a16e80 
EXT: wv_deepltranslate requires at least PHP 7.4, as stated in its
`composer.json` file. However, if the TYPO3 instance is a
non-Composer-based installation, the extension will be installed
regardless of the used PHP version, leading to hard crashes.

To catch this case, the PHP version constraint is added to
`ext_emconf.php`.

Fixes: web-vision#170
@andreaskienast andreaskienast mentioned this issue Mar 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Require PHP version in ext_emconf.php andreaskienast/wv_deepltranslate
1 participant
@andreaskienast