[BUGFIX] Require PHP version in ext_emconf.php #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EXT: wv_deepltranslate requires at least PHP 7.4, as stated in its `composer.json` file. However, if the TYPO3 instance is a non-Composer-based installation, the extension will be installed regardless of the used PHP version, leading to hard crashes. To catch this case, the PHP version constraint is added to `ext_emconf.php`. Fixes: web-vision#170
As Ext and TYPO3 v11 support PHP 8.2, this should be able in ext_emconf, too
calien666
approved these changes
Mar 19, 2023
|
Thanks for your work, as we have overlooked this. I changed to PHP 8.2, as we support this, too. After checks have passed, the PR will be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXT: wv_deepltranslate requires at least PHP 7.4, as stated in its
composer.jsonfile. However, if the TYPO3 instance is a non-Composer-based installation, the extension will be installed regardless of the used PHP version, leading to hard crashes.To catch this case, the PHP version constraint is added to
ext_emconf.php.Fixes: #170