Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs 1.0.x: Return type for generateSymKeyFromPassword incorrect #1924

Closed
levino opened this issue Sep 6, 2018 · 0 comments
Closed

Docs 1.0.x: Return type for generateSymKeyFromPassword incorrect #1924

levino opened this issue Sep 6, 2018 · 0 comments
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation

Comments

@levino
Copy link
Contributor

levino commented Sep 6, 2018

See https://web3js.readthedocs.io/en/1.0/web3-shh.html?highlight=generateSymKeyFromPassword#id61

The return type is either a Promise<string> iff no callback argument is given or undefined if a callback argument is given.
@levino levino mentioned this issue Sep 6, 2018
Merged
@nivida nivida added the Documentation Relates to project wiki or documentation label Oct 31, 2018
This was referenced Dec 1, 2018
Merged
Closed
@nivida nivida added the 1.x 1.0 related issues label Jun 20, 2019
nivida added a commit that referenced this issue Oct 23, 2019
@nivida
fixes #3133, #2724, #1924, and #1717
ced7fe7
@nivida nivida mentioned this issue Oct 23, 2019
Merged
nivida added a commit that referenced this issue Oct 24, 2019
@nivida
fixes #3133, #2724, #1924, and #1717
3788b8d
@nivida nivida closed this as completed Oct 24, 2019
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this issue Jun 4, 2020
@nivida @nachomazzara
fixes web3#3133, web3#2724, web3#1924, and web3#1717
64b8a1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@levino @nivida