Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth.accounts.sign() documentation is incomplete? #3133

Closed
No3371 opened this issue Oct 16, 2019 · 0 comments
Closed

eth.accounts.sign() documentation is incomplete? #3133

No3371 opened this issue Oct 16, 2019 · 0 comments
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation

Comments

@No3371
Copy link

No3371 commented Oct 16, 2019

Description

Some information is missing on the sign() documentation .

For example:

Parameters
data - String: The data to sign. If its a string it will be

be what?

Returns
... or if **returnSignature** is true the signature values as follows ...

Where is this returnSignature and what is it? It pops out from nowhere.
@nivida nivida added 1.x 1.0 related issues Documentation Relates to project wiki or documentation labels Oct 16, 2019
nivida added a commit that referenced this issue Oct 23, 2019
@nivida
fixes #3133, #2724, #1924, and #1717
ced7fe7
@nivida nivida mentioned this issue Oct 23, 2019
Merged
nivida added a commit that referenced this issue Oct 24, 2019
@nivida
fixes #3133, #2724, #1924, and #1717
3788b8d
@nivida nivida closed this as completed Oct 24, 2019
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this issue Jun 4, 2020
@nivida @nachomazzara
fixes web3#3133, web3#2724, web3#1924, and web3#1717
64b8a1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nivida @No3371