Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpProvider: CORS issue with Firefox and Safari #3112

Merged
merged 4 commits into from
Oct 8, 2019
Merged

HttpProvider: CORS issue with Firefox and Safari #3112

merged 4 commits into from
Oct 8, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 8, 2019

Fixes #2978 and adds the options property withCredentials.

@nivida nivida added Bug Addressing a bug In Progress Currently being worked on 1.x 1.0 related issues labels Oct 8, 2019
@nivida nivida closed this Oct 8, 2019
@nivida nivida reopened this Oct 8, 2019
@nivida nivida closed this Oct 8, 2019
@nivida nivida reopened this Oct 8, 2019
@nivida nivida changed the base branch from 2.x to 1.x October 8, 2019 19:29
@coveralls
Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage decreased (-0.01%) to 83.307% when pulling 8361f40 on issue/2978 into 28d52a9 on 1.x.

@nivida nivida removed the In Progress Currently being worked on label Oct 8, 2019
@nivida nivida requested a review from cgewecke October 8, 2019 19:56
@nivida nivida added the In Progress Currently being worked on label Oct 8, 2019
@nivida
Copy link
Contributor Author

nivida commented Oct 8, 2019

Added the in-progress label again because it can't find the global process var with nodejs v12.

@nivida nivida removed the In Progress Currently being worked on label Oct 8, 2019
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - it works in 2.x with no problems?

It would be cool to try to reproduce the CORS error (at least for Firefox) in headless browser testing but those fixtures need to be built.

What about docs changes for the new option?

@nivida
Copy link
Contributor Author

nivida commented Oct 8, 2019

@cgewecke Yeah, it's really strange and couldn’t clearly figure out why the process global var isn't existing in nodejs v12 for these tests.

It would be cool to try to reproduce the CORS error (at least for Firefox) in headless browser testing but those fixtures need to be built.

I wrote it down on my todo list and will mention it on the missing comment to your e2e issue.

What about docs changes for the new option?

Providers weren’t documented until now. I wrote that down on the todo list as well and will create a related issue for it today.

I will merge this PR for now.

@nivida nivida merged commit ce113d2 into 1.x Oct 8, 2019
@nivida nivida deleted the issue/2978 branch October 11, 2019 09:17
nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Bug Addressing a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants