Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.dap.ps is empty on IOS (develop 09.08.2019) #16

Closed
churik opened this issue Aug 9, 2019 · 94 comments · Fixed by #59 or #61
Closed

dev.dap.ps is empty on IOS (develop 09.08.2019) #16

churik opened this issue Aug 9, 2019 · 94 comments · Fixed by #59 or #61

Comments

@churik
Copy link

churik commented Aug 9, 2019

Description

Type: Bug
Summary: no dapps on dev.dap.ps on latest nightly, but they are shown for release 0.13.0

Expected behavior

can see dapps list

Actual behavior

IMG_A0A94BB6095F-1

Reproduction

  • restore account with STT
  • switch to Ropsten
  • open dev.dap.ps

Additional Information

  • Status version: nightly 09/08/2018
  • Operating System: iOS 11.4.1
@churik churik changed the title dev.dap.ps is empty for IOS (current develop) dev.dap.ps is empty on IOS (current develop) Aug 9, 2019
@churik churik changed the title dev.dap.ps is empty on IOS (current develop) dev.dap.ps is empty on IOS (develop 09.08.2019) Aug 9, 2019
@andytudhope
Copy link
Collaborator

Yeah, this was likely because we were working on it at the moment you tried. I am fairly sure this is fixed now so am happy to close. If you feel differently, please re-open.

@churik
Copy link
Author

churik commented Aug 9, 2019

@andytudhope
No, it is still empty for IOS on current develop. All fine on IOS (release 0.13.0) and on Android (current develop)

@andytudhope
Copy link
Collaborator

Can you clear your cache? It's really strange that it would work everywhere but on a specific branch & device...

@andytudhope andytudhope reopened this Aug 9, 2019
@andytudhope
Copy link
Collaborator

Please check this again when you get a chance, would be interesting to see if it is still empty with anew contract instance etc.

@churik
Copy link
Author

churik commented Aug 12, 2019

@andytudhope it is the same for me.
Asked Nastya to check on her side.

@asemiankevich
Copy link

@andytudhope same to me with iOS 13 Beta 4 (not sure if it matters).

image

image

@andytudhope
Copy link
Collaborator

Yeah, it definitely matters @asemiankevich... I'm just not sure what to do about it 😅 Is there any way you can clear your cache in Status? It's weird that it would load everywhere but on a a particular device. Any chance you could get web console logs to see if there's a clue there as to what might be happening?

@churik
Copy link
Author

churik commented Aug 12, 2019

@andytudhope I don't know how to clear cache in Status, in my case, I'm just creating new account.
And this is not about device as far as I understand - it is about the latest develop particularly on IOS.
All fine on 0.13.0 on IOS.

@andytudhope
Copy link
Collaborator

Ah, so it's the Status version... OK, any logs at all that you can get would be a good starting point...

@churik
Copy link
Author

churik commented Aug 12, 2019

That's all I can get for IOS:
geth.log
Just in case all app data (ping me for passwords):
im.status.ethereum.zip

@andytudhope
Copy link
Collaborator

Ha, it's hilarious trying to go through that... Anyway, here are some (maybe?) relevant parts:

t=2019-08-08T15:14:03+0000 lvl=eror msg="failed to get transfer in between two bloks" from=1600000 to=1700000 error="Post https://ropsten.infura.io/v3/f315575765b14720b32382a61a89341a: context deadline exceeded"
t=2019-08-08T15:14:03+0000 lvl=eror msg="failed to get next batch" error="Post https://ropsten.infura.io/v3/f315575765b14720b32382a61a89341a: context deadline exceeded"


t=2019-08-08T15:20:01+0000 lvl=eror msg="failed to get transfers" header=0x2e95c5206760e8eb0c1e9143a4d956c73b22607153da0f184a04f93245c6f76b error="Post https://ropsten.infura.io/v3/f315575765b14720b32382a61a89341a: context deadline exceeded"

t=2019-08-08T15:22:43+0000 lvl=eror msg="error while sending a contact code" namespace=Publisher site=tickerLoop error="sql: database is closed"

t=2019-08-09T09:36:44+0000 lvl=eror msg="failed to get transfers" header=0x6515571d96bd3885044d386cb519c95f669ef1b32d2c401e02af565925c8186d error="Post https://ropsten.infura.io/v3/f315575765b14720b32382a61a89341a: read tcp 192.168.1.15:61847->18.213.179.40:443: read: socket is not connected"

@churik
Copy link
Author

churik commented Aug 12, 2019

I believe you only need to check logs for last 10 mins (I created new account, switched to Ropsten and accessed de.dap.ps)
Sorry that didn't mention this earlier

@andytudhope
Copy link
Collaborator

@flexsurfer are you able to replicate this on iOS. I have an Linux machine and am travelling, so not able to replicate it at all. We need to try and figure out what is causing this on the latest release so that we can fix it. The logs attached to this issue are less than useless, so any insight you could help provide would be super beneficial in terms of getting this fixed...

@flexsurfer
Copy link
Collaborator

image

@flexsurfer
Copy link
Collaborator

i'm not sure if this is the reason, because i can see a list on ios even with these errors, how do you load a list of dapps ? do you get them from contract through web3 request? i can't see any logs in status

@flexsurfer
Copy link
Collaborator

ok if permission "always allow" i can see the XHR . request,
image

if not i can see error
image

@andytudhope
Copy link
Collaborator

andytudhope commented Oct 14, 2019

@iamonuwa are you able to look at this in the next 2 days? If so, I will create a bounty here ASAP.

@flexsurfer, yeah that is how we load them here and here

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented Oct 14, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 2 weeks from now.
Please review their action plans below:

1) iamonuwa has been approved to start work.

This is a known issue on all platforms.

  1. Investigate the problem (IndexedDB)
  2. Fix the problem.

ETA 3 days

Learn more on the Gitcoin Issue Details page.

@iamonuwa
Copy link
Contributor

@andytudhope you'll have the fix tonight

@gitcoinbot
Copy link

@iamonuwa Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@andytudhope
Copy link
Collaborator

Hey @iamonuwa - what is happening here? Even a small update would help me understand the blocking issue better.

@andytudhope
Copy link
Collaborator

Hello @iamonuwa? Testing, testing, 1 2 3?

@iamonuwa
Copy link
Contributor

@andytudhope the code looks good, I can't reproduce this on any of the devices I've tested it on. @churik here are my thoughts

  1. Ensure you are on a web3 enabled device.
  2. You are on the right network (mainnet) in this case.

The app will load on a browser without web3 but cannot pull data from the contract. If you use a wrong contract, it will also fail.

@churik
Copy link
Author

churik commented Oct 23, 2019

@iamonuwa which build are you using for testing?

@churik
Copy link
Author

churik commented Oct 23, 2019

I can reproduce issue:

  1. on released build, 0.13.2, URL: https://dap.ps, IPhone XS, IOS 12
  2. on current develop build, URL: https://dap.ps, IPhone 7, IOS 11.4.1

@jakubgs
Copy link
Contributor

jakubgs commented Dec 13, 2019

There's a possibility that Embark team might release 4.1.2 with web3 1.2.4 that we could use to possibly fix this issue. I say this because this fix is included in 1.2.4 which looks very promising:
web3/web3.js#3112

@flexsurfer
Copy link
Collaborator

but we still need to refactor a bit, show dapps list right after https://dap.ps/metadata/all call

@iamonuwa
Copy link
Contributor

but we still need to refactor a bit, show dapps list right after https://dap.ps/metadata/all call

Available as always 😁🙏

@flexsurfer
Copy link
Collaborator

ping @andytudhope

@jakubgs
Copy link
Contributor

jakubgs commented Dec 14, 2019

but we still need to refactor a bit, show dapps list right after https://dap.ps/metadata/all call

That sounds like a separate issue though.

@andytudhope
Copy link
Collaborator

Yeah, I think that it is, and I would still prefer to wait for Liquid Funding to be a thing for any kind of refactoring tbh. However, if you'd like to make a specific issue for that refactor @flexsurfer, I would be happy to put up a bounty.

@flexsurfer
Copy link
Collaborator

dap.ps is a crucial part of status app, because its the only way to discover dapps, currently it doesn't work, so no dapps, because it takes too long time to load on android and there is no list at all on ios, we can't ship v1 because of this blocker, to fix that we need to show list of dapps right after https://dap.ps/metadata/all call

@flexsurfer
Copy link
Collaborator

flexsurfer commented Dec 15, 2019

ok we can't show all dapps because we don't want to show not approved dapps , hm

@flexsurfer
Copy link
Collaborator

but in that case more dapps we'll have more time it will take to show dapps list, and later it might take like minutes to just show a list of dapps

jakubgs pushed a commit that referenced this issue Dec 17, 2019
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Contributor

jakubgs commented Dec 17, 2019

I just did a local build of discover dapp and deployed it at using the pre-release Embark version 4.1.2 from embarklabs/embark#2142 and it appears to work on Safari:
dap_ps_fixed_safari
I also tested it on my iPhone and it seems to work! Big thanks to @michaelsbradleyjr. Now we just have to wait for that version to be properly released.

@rachelhamlin
Copy link

It didn't occur to me that this is also blocking marketing. @flexsurfer since you're on v1 issues today, could you possibly prioritize this one? Sounds like latest Embark version might offer a simple fix? Though not clear to me if production ready.

@jakubgs
Copy link
Contributor

jakubgs commented Dec 18, 2019

Looks like the version of Embark we were anticipating is 4.2.0:
https://github.com/embark-framework/embark/releases/tag/v4.2.0
I will attempt to build to build discover with it tomorrow, too drunk now.

jakubgs pushed a commit that referenced this issue Dec 19, 2019
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Contributor

jakubgs commented Dec 19, 2019

Still not fixed.

@jakubgs
Copy link
Contributor

jakubgs commented Dec 19, 2019

I've deployed build from #61 on https://dev.dap.ps/, please test it.

@flexsurfer
Copy link
Collaborator

kudos @jakubgs works on ios and in safari

@StatusSceptre
Copy link

Brilliant. Also working for me. Thank you @jakubgs!

@flexsurfer
Copy link
Collaborator

can we deploy to dap.ps ?

@jakubgs
Copy link
Contributor

jakubgs commented Dec 19, 2019

I have deployed the changes to https://prod.dap.ps/, seem to work:
dap_ps_safari_success

@rachelhamlin
Copy link

prod.dap.ps works great on iOS! Although dap.ps doesn't point there.

@jakubgs
Copy link
Contributor

jakubgs commented Dec 19, 2019

prod.dap.ps is the same thing as dap.ps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants