Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#16] dev.dap.ps is empty on IOS (develop 09.08.2019) #59

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

flexsurfer
Copy link
Collaborator

@flexsurfer flexsurfer commented Dec 16, 2019

Show list first and then get data from the blockchain

fixes: #16

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this branch and deployed to https://dev.dap.ps/, but it's broken:

error TypeError: Cannot read property '0' of undefined
    at Dapps.reducer.js:40
    at h (runtime.js:45)
    at Generator._invoke (runtime.js:264)
    at Generator.t.<computed> [as next] (runtime.js:98)
    at n (asyncToGenerator.js:3)
    at a (asyncToGenerator.js:25)

Which seems to come from here:

const allDappsWithoutMeta = await discoverService.getAllDappsWithoutMetadata()
for (let i = 0; i < allDappsWithoutMeta.length; i++) {
dappSource = allDapps[i]

I fixed that locally and deployed again, seems to work well:
https://www.webpagetest.org/result/191217_9F_81f023bdf8614b8424844e68a6c49aaa/
Pushed the fix by amending the commit.

@flexsurfer
Copy link
Collaborator Author

thanks, @jakubgs i haven't' tested it locally because didn't want to spend much time on that, but it still doesn't work in safari :(

@jakubgs
Copy link
Contributor

jakubgs commented Dec 17, 2019

The trash browser fix is being done by Michael in: embarklabs/embark#2142

@jakubgs jakubgs merged commit d1f6545 into master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev.dap.ps is empty on IOS (develop 09.08.2019)
2 participants