build(deps): bump web3[-*] from 1.2.1 to 1.2.4 #2142
Conversation
DeepCode's analysis on #8acae6 found:
💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues. |
| @@ -9,7 +9,7 @@ const constants = require('embark-core/constants'); | |||
|
|
|||
| const DEFAULTS = { | |||
| "BIN": "geth", | |||
| "VERSIONS_SUPPORTED": ">=1.8.14", | |||
| "VERSIONS_SUPPORTED": ">=1.9.0", | |||
There was a problem hiding this comment.
Since we semi-break the version, maybe the new version should be 4.2?
There was a problem hiding this comment.
Yes, the intention is now to publish as 4.2.0, and I've updated to the PR description to that effect.
|
I have deployed this at: https://raw.dev.dap.ps/ |
|
Added don't merge yet label: I'm attempting an upgrade of ganache-cli to 6.7.0 on this branch. While embark's test runner in 4.1.x doesn't seem to make any usage of web3 v1.2.4 that involves the |
Refactor typings as necessary. In order for `bignumber.js` in the root `node_modules` to not conflict with `@types/bignumber.js`, specify `"bignumber.js": "5.0.0"` in `devDependencies` and `"embark-ui/bignumber.js"` in `nohoist` of the root `package.json`. Bump simples from 0.8.8 to 0.9.0-alpha-10 in `packages/embark-blockchain-process/package.json` and refactor `packages/embark-blockchain-process/src/proxy.js`. Drop simples as a dependency in `packages/embark/package.json` since it's not needed there. The upgrade of simples allows embark 4.2.x's proxy to work correctly with geth `>=1.9.1`. Bump ganache-cli from 6.4.3 to 6.7.0 (latest) because 6.4.3 doesn't support `eth_chainId` and since web3 1.2.4 makes use of the `eth_chainId` RPC method (EIP 695). BREAKING CHANGE: bump embark's minimum supported version of geth from `>=1.8.14` to `>=1.9.0` and its minimum supported version of parity from `>=2.0.0` to `>=2.2.1`. This is necessary since web3 1.2.4 makes use of the `eth_chainId` RPC method (EIP 695) and those client versions are the earliest ones to implement it.
michaelsbradleyjr
force-pushed
the
refactor-4.1.x/bump-web3
branch
from
04611ba
to
8acae66
Compare
|
PR description updated with respect to the intention to publish as embark v4.2.0. Also indicated the Also added a note (in PR description and commit message) re: the version bump of ganache-cli. |
NOTE: this PR is against the
4.1.x4.2.xbranch, which was created from thev4.1.1tag. If/when this PR is merged, and assuming no additional changes are necessary, the intention is to releasev4.1.24.2.0from the4.1.x4.2.xbranch.Refactor typings as necessary. In order for
bignumber.jsin the rootnode_modulesto not conflict with@types/bignumber.js, specify"bignumber.js": "5.0.0"indevDependenciesand"embark-ui/bignumber.js"innohoistof the rootpackage.json.Bump simples from 0.8.8 to 0.9.0-alpha-10 in
packages/embark-blockchain-process/package.jsonand refactorpackages/embark-blockchain-process/src/proxy.js. Drop simples as a dependency inpackages/embark/package.jsonsince it's not needed there. The upgrade of simples allows embark4.1.x's4.2.x's proxy to work correctly with geth>=1.9.1.Bump ganache-cli from 6.4.3 to 6.7.0 (latest) because 6.4.3 doesn't support
eth_chainIdand since web3 1.2.4 makes use of theeth_chainIdRPC method (EIP 695).BREAKING CHANGE: bump embark's minimum supported version of geth from
>=1.8.14to>=1.9.0and its minimum supported version of parity from>=2.0.0to>=2.2.1. This is necessary since web3 1.2.4 makes use of theeth_chainIdRPC method (EIP 695) and those client versions are the earliest ones to implement it.I've tested these changes by making a local release of
v4.1.2v4.2.0 with verdaccio andembark testing andembark runing status-teller-network and embark_demo with the local release. In the case of embark_demo the embark installation was global and in the case of teller it was local. Everything seemed to work as expected.