Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from @web3-js/scrypt-shim to scrypt-js #3536

Merged
merged 2 commits into from
May 26, 2020
Merged

Upgrade from @web3-js/scrypt-shim to scrypt-js #3536

merged 2 commits into from
May 26, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 22, 2020 •
edited
Loading

Description

This PR upgrades scrypt from @web3-js/scrypt-shim to scrypt-js, a pure JavaScript implementation.

Type of change

  • Dependency upgrade

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added dependencies 1.x 1.0 related issues labels May 22, 2020
@coveralls
Copy link

coveralls commented May 23, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 89.622% when pulling 2a73899 on use-scrypt-js into 6720ec0 on 1.x.

holgerd77
holgerd77 approved these changes May 25, 2020
View reviewed changes
Copy link
Collaborator

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side, eventually wait for an additional comment from @cgewecke before merge.

@cgewecke cgewecke self-requested a review May 26, 2020 14:57
cgewecke
cgewecke approved these changes May 26, 2020
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@cgewecke cgewecke merged commit 067ca10 into 1.x May 26, 2020
@cgewecke cgewecke deleted the use-scrypt-js branch May 26, 2020 14:58
@cgewecke cgewecke mentioned this pull request Jun 9, 2020
Closed
@cgewecke cgewecke mentioned this pull request Jun 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanio @coveralls @holgerd77 @cgewecke