Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a docs typo in subscribe migration guide #7325

Closed
wants to merge 4 commits into from
Closed

Fix a docs typo in subscribe migration guide #7325

wants to merge 4 commits into from

Conversation

Joro97
Copy link

@Joro97 Joro97 commented Oct 13, 2024 •
edited
Loading

Description

Fixes 7324 Fixing a small typo in subscribe migration guide.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Joro97 Joro97 mentioned this pull request Oct 13, 2024
Closed
@jdevcs
Copy link
Contributor

jdevcs commented Oct 14, 2024

cc: @danforbes

danforbes added a commit that referenced this pull request Oct 17, 2024
@danforbes
Fix Typo
1f71b68 
Closes #7324
Replaces #7325
@danforbes
Copy link
Contributor

Thank you for spotting this error @Joro97. In order to protect against airdrop farming, we have a policy against merging pull requests that only include very small typo changes. I have folded your corrections into an existing documentation PR that I am working on - #7334. Please feel free to refer to the Issues labeled "Good First Issue" if you're looking for ways to contribute to Web3.js.

@danforbes danforbes closed this Oct 17, 2024
danforbes added a commit that referenced this pull request Oct 21, 2024
@danforbes @krzysu
Intermediate dApp Guide (#7334)
fab66e9 
* Intermediate dApp Guide

Closes #7038

* Fix Typo

Closes #7324
Replaces #7325

* Update docs/docs/guides/07_dapps/intermediate-dapp.md

Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>

* Small Changes Based on Suggestion from @krzysu

---------

Co-authored-by: Kris <605420+krzysu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avkos avkos Awaiting requested review from avkos

@jdevcs jdevcs Awaiting requested review from jdevcs jdevcs is a code owner

@luu-alex luu-alex Awaiting requested review from luu-alex

@Muhammad-Altabba Muhammad-Altabba Awaiting requested review from Muhammad-Altabba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in subscribe migration guide
3 participants
@Joro97 @jdevcs @danforbes