Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webauthn4j version in webauthn4j-spring-security #1124

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

TGITS
Copy link
Contributor

@TGITS TGITS commented Feb 3, 2023

Update webauthn4j-spring-security to the latest version of webauthn4j published on maven central.

The update from 0.20.6 to 0.20.7 was surprisingly tricky due to the use by spring 2.7.x of a version 1.7.x of SL4J
(with the related 1.2.x version of logback)

For the time being mark as draft PR :

  • the solution to correct the problem with the tests is only a workaround, there is maybe a better solution, and in any case, the problem may need further discussion.
  • For now the version 0.20.8 of WebAuthn4j is not on Maven central for the first version of this PR but it will maybe come soon, and thus we can potentially directly update to the version 0.20.8.

TGITS and others added 2 commits February 3, 2023 10:44
Update wabauthn4j-spring-security to the latest version of webauthn4j published on maven central.

The update from 0.20.6 to 0.20.7 was surprisingly tricky due to the use by spring 2.7.x of a version 1.7.x of SL4J (with the related 1.2.x version of logback)
@ynojima ynojima marked this pull request as ready for review February 7, 2023 13:25
@ynojima
Copy link
Member

ynojima commented Feb 7, 2023

Thank you for your suggestion.
It seems it's root cause is webauthn4j-core and webauthn4j-util specify logback version unnecessarily in their poms. (webauthn4j-core and webauthn4j-util use logback in test module only.)
I'll fix it in the next webauthn4j version, but I'll merge this patch into webauthn4j-spring-security.

@ynojima ynojima merged commit 83aaa99 into webauthn4j:master Feb 7, 2023
@TGITS TGITS deleted the chore/update_webauthn4j_version branch March 10, 2023 15:23
@ynojima ynojima added this to the 0.8.0.RELEASE milestone Mar 18, 2023
@ynojima ynojima added the dependencies Pull requests that update a dependency file label Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

2 participants