Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webauthn4j version in webauthn4j-spring-security #1124

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Update webauthn4j version in webauthn4j-spring-security #1124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e01f1a
Merge pull request #1 from webauthn4j/master
TGITS Feb 3, 2023
013cd0f
chore(update_webauthn4j_version)
Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ buildscript {
httpBuilderVersion = '0.7.2'

//Libraries
webauthn4jVersion = '0.20.6.RELEASE'
webauthn4jVersion = '0.20.7.RELEASE'
springSecurityVersion = '5.7.6'
hibernateValidatorVersion = '6.2.5.Final'
thymeleafVersion = '3.0.4.RELEASE'
Expand All @@ -44,6 +44,13 @@ buildscript {
// To use WebAuthn WebDriver extension, alpha release is used here.
// When stable version is released, and Spring Boot BOM includes it, this need to be removed.
seleniumVersion = '4.8.0'

// To make the test pass without errors NoClassDefFoundError in samples/fido-server-conformance-test-app
// There is a compatibility issue between the versions of SLF4J/Logback used by webauthn4j and the versions used by Spring Boot 2.7.x
// There are breaking change in th SLF4J 2.x branche ("SLF4J API version 2.0.0 relies on the ServiceLoader mechanism to find its logging backend"
// and no any more on the StaticLoggerBinder see https://www.slf4j.org/manual.html).
// When upgrading to Spring Boot 3.x branche, this constant will have to be removed.
logbackSpringBoot27xCompatibilityVersion = '1.2.11'
}

repositories {
Expand Down
5 changes: 4 additions & 1 deletion samples/fido-server-conformance-test-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,10 @@ dependencies {
implementation("org.slf4j:jcl-over-slf4j")
implementation("org.modelmapper:modelmapper")
implementation('org.flywaydb:flyway-core')
runtimeOnly('ch.qos.logback:logback-classic')
//We have to force the use of this dependency
runtimeOnly("ch.qos.logback:logback-classic:$logbackSpringBoot27xCompatibilityVersion"){
force = true
}
runtimeOnly('com.h2database:h2')
runtimeOnly('com.mysql:mysql-connector-j')
runtimeOnly("org.lazyluke:log4jdbc-remix")
Expand Down
5 changes: 5 additions & 0 deletions samples/mpa/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ dependencies {
implementation('org.webjars:font-awesome:6.2.1')
implementation('org.webjars:webjars-locator:0.46')

//We have to force the use of this dependency
runtimeOnly("ch.qos.logback:logback-classic:$logbackSpringBoot27xCompatibilityVersion"){
force = true
}

//Test
testImplementation project(':webauthn4j-spring-security-test')
testImplementation('org.springframework.boot:spring-boot-starter-test')
Expand Down
5 changes: 4 additions & 1 deletion samples/spa/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ dependencies {
implementation("org.slf4j:jcl-over-slf4j")
implementation("org.modelmapper:modelmapper")
implementation('org.flywaydb:flyway-core')
runtimeOnly('ch.qos.logback:logback-classic')
//We have to force the use of this dependency
runtimeOnly("ch.qos.logback:logback-classic:$logbackSpringBoot27xCompatibilityVersion"){
force = true
}
runtimeOnly('com.h2database:h2')
runtimeOnly('com.mysql:mysql-connector-j')
runtimeOnly("org.lazyluke:log4jdbc-remix")
Expand Down