Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix physics component #158

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix physics component #158

wants to merge 7 commits into from

Conversation

arya3d
Copy link
Contributor

@arya3d arya3d commented Oct 14, 2022

I investigated the "physics" parameter issue in the .scn files
and I noticed that parameter is not being used anywhere
and the only reason we have had physics in objects is because we set it to true manually ( in app-manager.js )

so here's what I suggest we do :

  1. put the "physics" parameter in the "components" array in the .scn file
  2. make sure all of our scene files follow that rule
  3. update our docs

and finally here's what the user experiences :

  • If the physics component is not specified in the .scn file, we're going to enable physics for the object by default
  • If the physics component is set to true we enable and if it's set to false we disable physics for that object

@avaer
Copy link
Contributor

avaer commented Oct 24, 2022

Didn't this cause breakage in physics on testing?

Additionally,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants