Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.google.com - Labels option can not change state #111546

Closed
webcompat-bot opened this issue Sep 29, 2022 · 8 comments
Closed

www.google.com - Labels option can not change state #111546

webcompat-bot opened this issue Sep 29, 2022 · 8 comments
Assignees
Labels
browser-firefox diagnosis-priority-p2 engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Milestone

Comments

@webcompat-bot
Copy link

webcompat-bot commented Sep 29, 2022

URL: https://www.google.com/maps/

Browser / Version: Firefox 105.0
Operating System: Windows 10
Tested Another Browser: Yes Chrome

Problem type: Site is not usable
Description: Buttons or links not working
Steps to Reproduce:
The "turn labels off" button stopped working around the time of the latest update release (Sep 23, 2022), so now I'm stuck with all the annoying mumbo-jumbo obscuring the actual Orthophoto (satellite) view. If you go in the satellite view => Layers and try to turn the Labels off, nothing happens, the box remains ticked. I've tried removing all Google cookies, to no avail. Strangely enough, the tick box for Google Earth view works perfectly fine. The issue is non-existent in Chrome.

Browser Configuration
  • None

From webcompat.com with ❤️

@webcompat-bot webcompat-bot added the action-needsmoderation The moderation has not yet been completed label Sep 29, 2022
@webcompat-bot webcompat-bot added this to the needstriage milestone Sep 29, 2022
@webcompat-bot webcompat-bot added the browser-fixme This requires manual assignment for the browser name label Sep 29, 2022
@webcompat-bot webcompat-bot changed the title In the moderation queue. www.google.com - site is not usable Sep 29, 2022
@webcompat-bot webcompat-bot added browser-firefox engine-gecko The browser uses the Gecko rendering engine priority-critical and removed browser-fixme This requires manual assignment for the browser name action-needsmoderation The moderation has not yet been completed labels Sep 29, 2022
@softvision-raul-bucata
Copy link

We appreciate your report. I was able to reproduce the issue:

labels ff map n

Tested with:

Browser / Version: Firefox Release 105.0.1 (64-bit)/ Firefox Nightly 107.0a1 (2022-09-28) (64-bit) /Chrome Version Version 106.0.5249.62 (Official Build) (64-bit)
Operating System: Windows 10 PRO x64

Notes:

  1. Reproducible regardless of the status of ETP.
  2. Reproducible on the latest build of Firefox Nightly and Release.
  3. Works as expected using Chrome.

Moving this to NeedsDiagnosis for further investigations.

[qa_39/2022]

@softvision-raul-bucata softvision-raul-bucata changed the title www.google.com - site is not usable www.google.com - Labels option can not change state Sep 29, 2022
@softvision-raul-bucata softvision-raul-bucata added severity-important A non-core broken piece of functionality, not behaving the way you would expect. priority-normal and removed priority-critical labels Sep 29, 2022
@ksy36 ksy36 assigned ksy36 and unassigned denschub Nov 3, 2022
@ksy36
Copy link
Contributor

ksy36 commented Nov 3, 2022

There are a custom checkbox and button with disabled="false":

<button aria-checked="true" disabled="false" ved="1i:0,t:108128,e:9,p:Fj1kY97CKN-aptQPn8KrmA4:89" role="checkbox" jstcache="390" jsaction="layerswitcher.intent.labels" class="xzUcD" jsan="7.xzUcD,0.aria-checked,0.disabled,0.ved,0.role,22.jsaction"> <div jstcache="391" class="xXq44b iBueH" jsan="7.xXq44b,7.iBueH"></div> <div jstcache="392" style="display:none"></div> <label class="GKsdTb">Labels</label> </button>

but false on a disabled attribute has no effect. From https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#boolean-attribute :

To represent a false value, the attribute has to be omitted altogether.

So this button is "disabled" as long as attribute is present. Firefox doesn't fire events on disabled elements, so this would be https://bugzilla.mozilla.org/show_bug.cgi?id=1741231 and essentially https://bugzilla.mozilla.org/show_bug.cgi?id=1653882.

There is a discussion to change the behaviour in Chrome to match Firefox
see https://groups.google.com/a/chromium.org/g/blink-dev/c/9i0H0J0BzE4 and whatwg/html#5886.

I'll try to contact Google to see if someone could take a look at this since we keep getting reports.

@ksy36 ksy36 modified the milestones: needsdiagnosis, contactready Nov 3, 2022
@BeechComer
Copy link

I just ran into this issue. Now that the holidays are over, has there been anything from Google about this? Thanks!

@ANCT1
Copy link

ANCT1 commented Jan 18, 2023

Removing Labels in Firefox

Once you have completed the above steps you can deselect labels.

@ksy36
Copy link
Contributor

ksy36 commented Jan 24, 2023

I just ran into this issue. Now that the holidays are over, has there been anything from Google about this? Thanks!

No response so far unfortunately. I've filed a bug to investigate if we can add an intervention https://bugzilla.mozilla.org/show_bug.cgi?id=1812074 on our side.

@ksy36 ksy36 added action-needssitepatch This web bug needs a GoFaster site patch. and removed status-needsinfo-ksy36 ping @ksy36 labels Jan 24, 2023
@ksy36 ksy36 modified the milestones: contactready, sitewait Jan 24, 2023
@BeechComer
Copy link

@ANCT1 Thanks!
@ksy36 Thanks for that, hope you hear something back!

@wisniewskit
Copy link
Member

Funny enough, while I was in the middle of writing a site patch for this one, it appears that Google fixed it.

@wisniewskit wisniewskit modified the milestones: sitewait, fixed Feb 8, 2023
@BeechComer
Copy link

BeechComer commented Feb 11, 2023 via email

@ksy36 ksy36 removed the action-needssitepatch This web bug needs a GoFaster site patch. label Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-firefox diagnosis-priority-p2 engine-gecko The browser uses the Gecko rendering engine priority-normal severity-important A non-core broken piece of functionality, not behaving the way you would expect.
Projects
None yet
Development

No branches or pull requests

7 participants