Skip to content

Commit

Permalink
Adding conventions for reviews. Fix #360
Browse files Browse the repository at this point in the history
  • Loading branch information
karlcow committed Nov 10, 2014
1 parent 321d53b commit 4ef966b
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,16 @@ You'll probably want to [set up a local development environment](#working-enviro

![master](https://cldup.com/YVlLDGItPf-3000x3000.png)

When sending the pull request do not forget to call out someone for review by using the following convention:

`r? @miketaylr`

This will notify the person that your request is waiting for a review for merging. Ask a review only by one person, this will avoid misunderstandings and the ball is dropped. (Python: karlcow, miketaylr. JavaScript: magsout, miketaylr, tagawa CSS: magsout).

* Continue discussion in the pull request.

The discussion might lead to modify or abandon this specific pull request. This is the place where you can have a code review.

After all that, if you'd like, you can send a pull request to add your name to our humans.txt file.

## Coding Style
Expand Down

0 comments on commit 4ef966b

Please sign in to comment.