Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Pull Request Reviews #360

Closed
karlcow opened this issue Nov 10, 2014 · 0 comments
Closed

[docs] Pull Request Reviews #360

karlcow opened this issue Nov 10, 2014 · 0 comments

Comments

@karlcow
Copy link
Member

karlcow commented Nov 10, 2014

  1. Someone creates a new issue
  2. Might reference a previous issue happening in the discussion like for this issue Add FlashMessageComponent #326
  3. Create a branch. Quick tip add the number of the issue in your branch name.
  4. Commit with the number of the issue.
  5. Create a pull request against master on webcompat.com
  6. Ask someone to review the Pull Request with r? @miketaylr for example.

To add to the CONTRIBUTING.md
miketaylr pushed a commit that referenced this issue Nov 10, 2014
Merge pull request #361 from karlcow/360-docs
905f9a2 
Adding conventions for reviews. Fix #360
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow