Merge pull request #393 from webcompat/387/1

Fix for #387 - Don't request /labels unless logged in.

webcompat/static/js/lib/labels.js

@@ -15,6 +15,7 @@ issues.AllLabels = Backbone.Model.extend({
 });
 
 issues.LabelsView = Backbone.View.extend({
+  _isLoggedIn: $('body').data('username'),
   el: $('.Label-wrapper'),
   editorButton: null,
   events: {
@@ -45,19 +46,20 @@ issues.LabelsView = Backbone.View.extend({
     this.$el.html(this.template(this.model.toJSON()));
   },
   fetchLabels: function() {
-    var self = this;
     var headersBag = {headers: {'Accept': 'application/json'}};
     this.editorButton = $('.LabelEditor-launcher');
     this.allLabels = new issues.AllLabels();
     this.labelEditor = new issues.LabelEditorView({
       model: this.allLabels,
       issueView: this,
     });
-    this.allLabels.fetch(headersBag).success(function(){
-      self.issueLabels = _.bind(self.getIssueLabels, self);
-      self.repoLabels = _.pluck(self.labelEditor.model.get('labels'), 'name');
-      self.editorButton.show();
-    });
+    if (this._isLoggedIn) {
+      this.allLabels.fetch(headersBag).success(_.bind(function(){
+        this.issueLabels = this.getIssueLabels();
+        this.repoLabels = _.pluck(this.labelEditor.model.get('labels'), 'name');
+        this.editorButton.show();
+      }, this));
+    }
   },
   getIssueLabels: function() {
     return _.pluck(this.model.get('labels'), 'name');

webcompat/static/js/lib/models/issue.js

@@ -99,7 +99,7 @@
       url: '/api/issues/' + this.get('number') + '/labels',
       success: function(response) {
         //update model after success
-        self.set('labels', JSON.parse(response));
+        self.set('labels', response);
       },
       error: function() {
         $('<div></div>', {