Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not request labels when not logged #387

Closed
karlcow opened this issue Nov 13, 2014 · 2 comments
Closed

Do not request labels when not logged #387

karlcow opened this issue Nov 13, 2014 · 2 comments
Labels
type: bug type: site-development

Comments

@karlcow
Copy link
Member

karlcow commented Nov 13, 2014

When the user is not logged to github, we should not request labels.
/api/issues/labels will result in a 401 Not Authorized

labels-401
@miketaylr
Copy link
Member

Good find. Definitely a bug.

miketaylr pushed a commit that referenced this issue Nov 13, 2014
Issue #387 - Don't try to parse an already parsed object.
e6bb808
miketaylr pushed a commit that referenced this issue Nov 13, 2014
Issue #387 - Don't request all labels unless logged in.
77731f3
magsout added a commit that referenced this issue Nov 14, 2014
@magsout
Merge pull request #393 from webcompat/387/1
66141be 
Fix for #387 - Don't request /labels unless logged in.
@miketaylr
Copy link
Member

This is fixed on master.

@MaxMood96 MaxMood96 mentioned this issue Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug type: site-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@miketaylr @karlcow