Skip to content

Commit

Permalink
Issue #421 - Added link underline and hover to yellow
Browse files Browse the repository at this point in the history
  • Loading branch information
magsout committed Dec 9, 2014
1 parent 2067ecd commit d02fcde
Show file tree
Hide file tree
Showing 8 changed files with 18 additions and 10 deletions.
5 changes: 4 additions & 1 deletion webcompat/static/css/development/components/footer.css
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@
padding-right:0 ;
}
/* link */
.wc-Footer-item-link:after {
.wc-Footer-item-link {
text-decoration:none;
}
.wc-Footer-item-link--separator:after {
content:"//";
margin-left:1em;
}
Expand Down
1 change: 1 addition & 0 deletions webcompat/static/css/development/components/labels.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
font-weight:700;
border-color:transparent;
opacity:.7;
text-decoration:none;
}
/* state */
.wc-Labels:hover {
Expand Down
4 changes: 4 additions & 0 deletions webcompat/static/css/development/page/home.css
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
margin-bottom:10px;
font-weight:500;
}
/* link */
.wc-titleIssue-link {
text-decoration:none;
}

#howitworks,
#join,
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/browse-issues/needs-diagnosis.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="needs-diagnosis" class="r-Grid-cell r-all--1of2 r-maxM--2of2">
<script type="text/template" id="needs-diagnosis-tmpl">
<h3 class="wc-titleIssue">
<a class="no-underline" href="{{ url_for('show_issues') }}?needsdiagnosis=1">Needs Diagnosis</a>
<a class="wc-titleIssue-link" href="{{ url_for('show_issues') }}?needsdiagnosis=1">Needs Diagnosis</a>
</h3>
<% if (needsDiagnosis.length) { %>
<% _.each(needsDiagnosis, function(issue) { %>
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/browse-issues/ready-for-outreach.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="ready-for-outreach" class="r-Grid-cell r-all--1of2 r-maxM--2of2">
<script type="text/template" id="contactready-tmpl">
<h3 class="wc-titleIssue">
<a class="no-underline" href="{{ url_for('show_issues') }}?contactready=1">Ready for Outreach</a>
<a class="wc-titleIssue-link" href="{{ url_for('show_issues') }}?contactready=1">Ready for Outreach</a>
</h3>
<% if (contactReady.length) { %>
<% _.each(contactReady, function(issue) { %>
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/browse-issues/site-contacted.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="sitewait" class="r-Grid-cell r-all--1of2 r-maxM--2of2">
<script type="text/template" id="sitewait-tmpl">
<h3 class="wc-titleIssue">
<a class="no-underline" href="{{ url_for('show_issues') }}?sitewait=1">Site Contacted</a>
<a class="wc-titleIssue-link" href="{{ url_for('show_issues') }}?sitewait=1">Site Contacted</a>
</h3>
<% if (sitewait.length) { %>
<% _.each(sitewait, function(issue) { %>
Expand Down
2 changes: 1 addition & 1 deletion webcompat/templates/browse-issues/untriaged.html
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div id="untriaged" class="r-Grid-cell r-all--1of2 r-maxM--2of2">
<script type="text/template" id="untriaged-tmpl">
<h3 class="wc-titleIssue">
<a class="no-underline" href="{{ url_for('show_issues') }}?untriaged=1">Untriaged Issues</a>
<a class="wc-titleIssue-link" href="{{ url_for('show_issues') }}?untriaged=1">Untriaged Issues</a>
</h3>
<% if (untriaged.length) { %>
<% _.each(untriaged, function(issue) { %>
Expand Down
10 changes: 5 additions & 5 deletions webcompat/templates/shared/footer.html
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<footer class="wc-Footer">
<div class="wc-content wc-content--footer">
<ul class="wc-Footer-section wc-Footer-section--left">
<li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator no-underline" href="{{ url_for('about') }}">About</a></li><!--
--><li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator no-underline" href="{{ url_for('privacy') }}">Privacy Policy</a></li><!--
--><li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator no-underline" href="/humans.txt">Contact</a></li><!--
--><li class="wc-Footer-item"><a class="no-underline" href="{{ url_for('contributors') }}">Contribute</a></li>
<li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator" href="{{ url_for('about') }}">About</a></li><!--
--><li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator" href="{{ url_for('privacy') }}">Privacy Policy</a></li><!--
--><li class="wc-Footer-item"><a class="wc-Footer-item-link wc-Footer-item-link--separator" href="/humans.txt">Contact</a></li><!--
--><li class="wc-Footer-item"><a class="wc-Footer-item-link" href="{{ url_for('contributors') }}">Contribute</a></li>
</ul>
<ul class="wc-Footer-section wc-Footer-section--right">
<li class="wc-Footer-item wc-Footer-item--follow"><a class="no-underline" href="https://twitter.com/intent/user?screen_name=webcompat" target="_blank">Follow @WebCompat</a></li>
<li class="wc-Footer-item wc-Footer-item--follow"><a class="wc-Footer-item-link" href="https://twitter.com/intent/user?screen_name=webcompat" target="_blank">Follow @WebCompat</a></li>
</ul>
</div>
</footer>

0 comments on commit d02fcde

Please sign in to comment.