Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to see clickable links on the /contributors page #421

Closed
vladikoff opened this issue Nov 21, 2014 · 5 comments
Closed

Hard to see clickable links on the /contributors page #421

vladikoff opened this issue Nov 21, 2014 · 5 comments

Comments

@vladikoff
Copy link
Member

For instance:
image

I had no clue that "Contributions welcome!" is a link until I hovered

@miketaylr
Copy link
Member

Yeah. I think all links should be underlined by default. Thanks @vladikoff.

Thoughts @magsout @calexity?

@calexity
Copy link
Contributor

Yes, we should underline them. A usability bug that I have neglected.
Thanks for pointing it out @vladikoff

For a hover state, they can hover to our yellow color.

On Fri, Nov 21, 2014, 2:29 PM Mike Taylor notifications@github.com wrote:

Yeah. I think all links should be underlined by default. Thanks @vladikoff
https://github.com/vladikoff.

Thoughts @magsout https://github.com/magsout @calexity
https://github.com/calexity?


Reply to this email directly or view it on GitHub
#421 (comment)
.

@karlcow
Copy link
Member

karlcow commented Nov 24, 2014

Everywhere on the site we need to fix the links. Agreed with @vladikoff
I meant to open this bug for a while. I keep on my bottom list. So glad it's here.

@magsout
Copy link
Member

magsout commented Nov 25, 2014

2 ideas

  • underline all link / changes color hover
  • dark link / underline hover

@tagawa
Copy link
Member

tagawa commented Dec 3, 2014

Another option:

  • underline all links / remove underline on hover

which is the opposite of what we have now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants