Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #421 - Added link underline and hover to yellow #438

Merged
merged 2 commits into from
Dec 9, 2014
Merged

Conversation

calexity
Copy link
Contributor

@calexity calexity commented Dec 4, 2014

#421

This is a bit strange - maybe @magsout can fix it. The new style for links is:
-underline and hover to yellow
-if background is already yellow, hover to white

I added a class .no-underline which I used on the Footer and on the Browse Issues statuses to remove the underline.

@miketaylr
Copy link
Member

Let's ask Guillaume to review. 😄

r? @magsout

@magsout
Copy link
Member

magsout commented Dec 4, 2014

Oh yeah sorry. I'll review this night

@magsout
Copy link
Member

magsout commented Dec 5, 2014

@calexity

This is a bit strange - maybe @magsout can fix it.

What is a bit strange ?

@calexity
Copy link
Contributor Author

calexity commented Dec 5, 2014

I added the no-underline class which seemed weird but if you are OK with
it, I'm OK with it:)

On Thu, Dec 4, 2014, 10:23 PM Guillaume Demesy notifications@github.com
wrote:

@calexity https://github.com/calexity

This is a bit strange - maybe @magsout https://github.com/magsout can
fix it.

What is a bit strange ?


Reply to this email directly or view it on GitHub
#438 (comment)
.

@miketaylr miketaylr changed the title Added link underline and hover to yellow Fixes #421 - Added link underline and hover to yellow Dec 6, 2014
@magsout
Copy link
Member

magsout commented Dec 9, 2014

Just fixed some trouble with Label and Footer Component.

It's OK, thanks @calexity

magsout added a commit that referenced this pull request Dec 9, 2014
Fixes #421 - Added link underline and hover to yellow
@magsout magsout merged commit 58c2f1a into master Dec 9, 2014
@magsout magsout deleted the fixlinkstyle branch December 9, 2014 20:37
@calexity
Copy link
Contributor Author

Thank you @magsout!
On Tue, Dec 9, 2014 at 12:37 PM Guillaume Demesy notifications@github.com
wrote:

Merged #438 #438.


Reply to this email directly or view it on GitHub
#438 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants