Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failures related to new issue redesign. #1236

Closed
miketaylr opened this issue Dec 10, 2016 · 2 comments
Closed

Fix test failures related to new issue redesign. #1236

miketaylr opened this issue Dec 10, 2016 · 2 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

miketaylr commented Dec 10, 2016 •
edited
Loading 

FAIL: main - Issues - Issue page loads (442ms)

AssertionError: Issue title displayed: expected 'Blah blah' to include 'Issue 100:'

FAIL: main - Issues - Opening the QR code image (via button) (10663ms)

FAIL: main - Issues - Closing the QR code image (via button) (10677ms)

FAIL: main - Issues - Opening the QR code image (via keyboard shortcut) (10638ms)

FAIL: main - Issues (auth) - Closing and reopening an issue (10714ms)
@miketaylr
Copy link
Member Author

Fixed the first one, seems like we forgot about the QR code stuff for the new design?

miketaylr pushed a commit that referenced this issue Dec 10, 2016
Issue #1236. Update Issue page loads test.
44e973a
@miketaylr
Copy link
Member Author

So let's just remove the QR code tests that are failing, and I'll file a follow up issue to enable them (if we still want them).

miketaylr pushed a commit that referenced this issue Dec 13, 2016
Issue #1236. Disable QR code tests.
4c85c31
@miketaylr miketaylr mentioned this issue Dec 13, 2016
Closed
miketaylr pushed a commit that referenced this issue Dec 13, 2016
Issue #1236. Test should match fixture data.
ae3beb1
miketaylr pushed a commit that referenced this issue Dec 13, 2016
Issue #1236. Update expected markup for issues test.
1ba502d
miketaylr pushed a commit that referenced this issue Dec 13, 2016
Issue #1236. Use assert.include rather than assert.equal.
bfa3ea9 
(The new state text includes the issue number.)
@miketaylr miketaylr self-assigned this Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miketaylr