Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove QR-related code on issue page #1239

Closed
miketaylr opened this issue Dec 13, 2016 · 6 comments
Closed

Remove QR-related code on issue page #1239

miketaylr opened this issue Dec 13, 2016 · 6 comments
Assignees
@miketaylr

Comments

@miketaylr
Copy link
Member

We unintentionally didn't include it in the new issue page redesign. Do we re-include it? Or remove it for-reals? Right now we're including the JS on the page but it won't do anything, so we should make a decision one way or the other.
@miketaylr
Copy link
Member Author

cc @tagawa @karlcow @magsout

@miketaylr
Copy link
Member Author

Disabled in #1236.

@tagawa
Copy link
Member

tagawa commented Dec 14, 2016

As much as I love QR codes, it seems they're not used that much in other countries so perhaps it's not that necessary. One option is to wait and see if there are any "hey, where'd it go?" comments.

@magsout
Copy link
Member

magsout commented Dec 14, 2016

Agree with @tagawa

@miketaylr
Copy link
Member Author

That seems reasonable.

@miketaylr miketaylr changed the title Re-enable QR code on issue page? Remove QR-related code on issue page Dec 14, 2016
@miketaylr
Copy link
Member Author

Let's use this issue to remove, and keep our eyes open for users who want it back.

@miketaylr miketaylr self-assigned this Dec 14, 2016
miketaylr pushed a commit that referenced this issue Dec 14, 2016
Issue #1239. Remove QR code related code.
be21730
miketaylr pushed a commit that referenced this issue Dec 16, 2016
Issue #1239. Remove QR code related code.
3ff8be8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miketaylr miketaylr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@miketaylr @tagawa @magsout