-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get tests to pass with PRs from forks. #1665
Labels
Comments
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
brizental
added a commit
to brizental/webcompat.com
that referenced
this issue
Aug 11, 2017
…for OS X builds.
miketaylr
pushed a commit
that referenced
this issue
Aug 11, 2017
Fixes #1665 - Gets tests to pass with PRs from forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So, we use some encrypted variables in Travis and that is why the tests don't pass for forks.
Talking to @miketaylr, we decided it would be best to just go around the tests that need these secure variables for now. Basically make a subset of tests that don't need them for when the PR is from a fork.
Not ideal, but there is an open issue for encrypted vars to work with forks in the Travis repo (travis-ci/travis-ci#1946). We could watch that and when it's done we could let any PR run all tests.
[EDIT]
So, I figured if we get all tests to always mock all responses and stuff, basically, get them all to work offline, we wouldn't need anymore secure variables and then all tests would always run for everyone.
So now what's needed for this to work is:
NOTE: funcional tests are already all working offline (see: Fixes #1620 - Gets all functional tests to work offline. #1625 )
The text was updated successfully, but these errors were encountered: