Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests to pass with PRs from forks. #1665

Closed
2 tasks done
brizental opened this issue Jul 18, 2017 · 0 comments
Closed
2 tasks done

Get tests to pass with PRs from forks. #1665

brizental opened this issue Jul 18, 2017 · 0 comments
Assignees

Comments

@brizental
Copy link
Contributor

brizental commented Jul 18, 2017

So, we use some encrypted variables in Travis and that is why the tests don't pass for forks.

Talking to @miketaylr, we decided it would be best to just go around the tests that need these secure variables for now. Basically make a subset of tests that don't need them for when the PR is from a fork.

Not ideal, but there is an open issue for encrypted vars to work with forks in the Travis repo (travis-ci/travis-ci#1946). We could watch that and when it's done we could let any PR run all tests.

[EDIT]

So, I figured if we get all tests to always mock all responses and stuff, basically, get them all to work offline, we wouldn't need anymore secure variables and then all tests would always run for everyone.

So now what's needed for this to work is:

@brizental brizental self-assigned this Jul 20, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
brizental added a commit to brizental/webcompat.com that referenced this issue Aug 11, 2017
miketaylr pushed a commit that referenced this issue Aug 11, 2017
Fixes #1665 - Gets tests to pass with PRs from forks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants