Fixes #1665 - Gets tests to pass with PRs from forks. #1710
+8
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brizental
changed the title
brizental
force-pushed
the
issues/1665/1
branch
2 times, most recently
from
7e061f2 to
5062eca
Compare
brizental
changed the title
yeah, +1. not as cool as i thought it would be. |
brizental
force-pushed
the
issues/1665/1
branch
from
f95ac49 to
1dc9c65
Compare
miketaylr
reviewed
Aug 11, 2017
| @@ -18,14 +18,9 @@ cache: | |||
| git: | |||
| depth: 5 | |||
|
|
|||
| addons: | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
miketaylr
approved these changes
Aug 11, 2017
| # this file is only important in non-test mode. | ||
| # in test mode everything must be mocked, | ||
| # so there is no external api communication. | ||
| config_validator() |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -20,15 +20,6 @@ define( | |||
| return params ? base + params : base; | |||
| }; | |||
|
|
|||
| function takeScreenshot() { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @miketaylr
I removed the screenshot capability because it was making it harder to read the Travis console. We can put it back after this, but I didn't see much use to it in the first place. What do you think, @miketaylr ?